You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Adam Wang (Jira)" <ji...@apache.org> on 2020/12/08 01:53:00 UTC
[jira] [Created] (HBASE-25370) Fix flaky test
TestClassFinder#testClassFinderDefaultsToOwnPackage
Adam Wang created HBASE-25370:
---------------------------------
Summary: Fix flaky test TestClassFinder#testClassFinderDefaultsToOwnPackage
Key: HBASE-25370
URL: https://issues.apache.org/jira/browse/HBASE-25370
Project: HBase
Issue Type: Test
Reporter: Adam Wang
The test {{TestClassFinder#testClassFinderDefaultsToOwnPackage}} compares two sets from {{allClassesFinder.findClasses}}. However, the function {{allClassesFinder.findClasses}} does not return the deterministic order result. From code trace, the root cause is at {{ClassFinder.findClassesFromJar}} and {{ClassFinder.findClassesFromFiles}}. They use {{HashSet}} to store {{classes}} and {{listFiles}} to get file array. However, {{HashSet}} and {{listFiles}} do not guarantee that order, and the assertion can fail if the order differs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)