[GitHub] [ozone] Tejaskriya commented on a diff in pull request #4538: HDDS-7752. GetS3SecretRequest API should not return secret if secret of user already exists

["Tejaskriya (via GitHub)" <gi...@apache.org>]

Tejaskriya commented on code in PR #4538:
URL: https://github.com/apache/ozone/pull/4538#discussion_r1172252179


##########
hadoop-ozone/dist/src/main/smoketest/security/ozone-secure-tenant.robot:
##########
@@ -85,10 +85,6 @@ SetSecret Failure For Invalid Secret 2
     ${rc}  ${output} =  Run And Return Rc And Output  ozone tenant user setsecret 'tenantone$testuser' --secret=short
                         Should contain   ${output}         Secret key length should be at least 8 characters
 
-GetSecret Success

Review Comment:
   The test intends to test getsecret for tenant. Refer to this comment: https://github.com/apache/ozone/pull/4538#discussion_r1161453347. The effect of this change on Tenant getsecret- It makes it obsolete. Hence the test was removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org