You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kylin.apache.org by sh...@apache.org on 2018/11/28 11:19:39 UTC

[kylin] branch master updated: minor, remove a deprecated configuration("kylin.job.lock") usage in the code.

This is an automated email from the ASF dual-hosted git repository.

shaofengshi pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/kylin.git


The following commit(s) were added to refs/heads/master by this push:
     new be5df4a  minor, remove a deprecated configuration("kylin.job.lock") usage in the code.
be5df4a is described below

commit be5df4a8bb6939c0c62c6135c4312fe3ad56775d
Author: Jiatao Tao <24...@qq.com>
AuthorDate: Wed Nov 28 15:00:30 2018 +0800

    minor, remove a deprecated configuration("kylin.job.lock") usage in the code.
---
 .../org/apache/kylin/job/impl/threadpool/DistributedScheduler.java     | 3 +--
 .../test/java/org/apache/kylin/job/BaseTestDistributedScheduler.java   | 2 --
 2 files changed, 1 insertion(+), 4 deletions(-)

diff --git a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java
index a998873..c33b21b 100644
--- a/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java
+++ b/core-job/src/main/java/org/apache/kylin/job/impl/threadpool/DistributedScheduler.java
@@ -58,8 +58,7 @@ import com.google.common.collect.Maps;
  *
  * to enable the distributed job server, you need to set and update three configs in the kylin.properties:
  *  1. kylin.job.scheduler.default=2
- *  2. kylin.job.lock=org.apache.kylin.storage.hbase.util.ZookeeperJobLock
- *  3. add all the job servers and query servers to the kylin.server.cluster-servers
+ *  2. add all the job servers and query servers to the kylin.server.cluster-servers
  */
 public class DistributedScheduler implements Scheduler<AbstractExecutable>, ConnectionStateListener {
     private static final Logger logger = LoggerFactory.getLogger(DistributedScheduler.class);
diff --git a/kylin-it/src/test/java/org/apache/kylin/job/BaseTestDistributedScheduler.java b/kylin-it/src/test/java/org/apache/kylin/job/BaseTestDistributedScheduler.java
index be54dce..cc5add0 100644
--- a/kylin-it/src/test/java/org/apache/kylin/job/BaseTestDistributedScheduler.java
+++ b/kylin-it/src/test/java/org/apache/kylin/job/BaseTestDistributedScheduler.java
@@ -69,7 +69,6 @@ public class BaseTestDistributedScheduler extends HBaseMetadataTestCase {
     @BeforeClass
     public static void setup() throws Exception {
         staticCreateTestMetadata();
-        System.setProperty("kylin.job.lock", "org.apache.kylin.storage.hbase.util.ZookeeperDistributedJobLock");
 
         new File(confDstPath1).getParentFile().mkdirs();
         new File(confDstPath2).getParentFile().mkdirs();
@@ -128,7 +127,6 @@ public class BaseTestDistributedScheduler extends HBaseMetadataTestCase {
         }
 
         FileUtils.deleteDirectory(localMetaDir);
-        System.clearProperty("kylin.job.lock");
         System.clearProperty("kylin.metadata.url");
         staticCleanupTestMetadata();
     }