You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Bill Farner <wf...@apache.org> on 2017/09/27 16:06:55 UTC
Review Request 62620: Fix binding issues preventing ./gradle run from
working
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62620/
-----------------------------------------------------------
Review request for Aurora and David McLaughlin.
Repository: aurora
Description
-------
A few things going on here:
- when running `LocalSchedulerMain`, a binding was missing for `@HydrateSnapshotFields Set<String>`
- `ClusterSimulatorModule` was binding `Set<Offer>` from the `org.apache.mesos.v1` package, but the consumer was using `org.apache.mesos`. Ouch - be on the lookout for this!
- I added a hack to make guice binding errors less awful. I'd like to work through the tangle of deps to get us to guice 4 soon and make this situation better. [History](https://github.com/google/guice/issues/757) for those interested.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 3fbe99c4f1af1f11403bf08155bb4be028132e38
src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 7a342bd82063922ad622237168a4aae76172359f
src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 963e4dc97845f96554d74df633b49c26341468fa
Diff: https://reviews.apache.org/r/62620/diff/1/
Testing
-------
`./gradlew run` works
Thanks,
Bill Farner
Re: Review Request 62620: Fix binding issues preventing ./gradle run
from working
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62620/#review186444
-----------------------------------------------------------
Master (474320b) is red with this patch.
./build-support/jenkins/build.sh
@Forward(AnnotatedAuroraAdmin.class)
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processTestResources
:testClasses
:compileJmhJavaNote: /home/jenkins/jenkins-slave/workspace/AuroraBot/src/jmh/java/org/apache/aurora/benchmark/fakes/FakeSchedulerDriver.java uses or overrides a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processJmhResources NO-SOURCE
:jmhClasses
:checkstyleJmh
:checkstyleMain
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java:192: System.out.println is used
:pmdMain FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':pmdMain'.
> 1 PMD rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/pmd/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
* Get more help at https://help.gradle.org
BUILD FAILED in 5m 3s
46 actionable tasks: 37 executed, 9 up-to-date
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 27, 2017, 4:06 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62620/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 4:06 p.m.)
>
>
> Review request for Aurora and David McLaughlin.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> A few things going on here:
> - when running `LocalSchedulerMain`, a binding was missing for `@HydrateSnapshotFields Set<String>`
> - `ClusterSimulatorModule` was binding `Set<Offer>` from the `org.apache.mesos.v1` package, but the consumer was using `org.apache.mesos`. Ouch - be on the lookout for this!
> - I added a hack to make guice binding errors less awful. I'd like to work through the tangle of deps to get us to guice 4 soon and make this situation better. [History](https://github.com/google/guice/issues/757) for those interested.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 3fbe99c4f1af1f11403bf08155bb4be028132e38
> src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 7a342bd82063922ad622237168a4aae76172359f
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 963e4dc97845f96554d74df633b49c26341468fa
>
>
> Diff: https://reviews.apache.org/r/62620/diff/1/
>
>
> Testing
> -------
>
> `./gradlew run` works
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62620: Fix binding issues preventing ./gradle run
from working
Posted by Jordan Ly <jo...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62620/#review186443
-----------------------------------------------------------
Ship it!
Ship It!
- Jordan Ly
On Sept. 27, 2017, 4:06 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62620/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 4:06 p.m.)
>
>
> Review request for Aurora and David McLaughlin.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> A few things going on here:
> - when running `LocalSchedulerMain`, a binding was missing for `@HydrateSnapshotFields Set<String>`
> - `ClusterSimulatorModule` was binding `Set<Offer>` from the `org.apache.mesos.v1` package, but the consumer was using `org.apache.mesos`. Ouch - be on the lookout for this!
> - I added a hack to make guice binding errors less awful. I'd like to work through the tangle of deps to get us to guice 4 soon and make this situation better. [History](https://github.com/google/guice/issues/757) for those interested.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 3fbe99c4f1af1f11403bf08155bb4be028132e38
> src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 7a342bd82063922ad622237168a4aae76172359f
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 963e4dc97845f96554d74df633b49c26341468fa
>
>
> Diff: https://reviews.apache.org/r/62620/diff/1/
>
>
> Testing
> -------
>
> `./gradlew run` works
>
>
> Thanks,
>
> Bill Farner
>
>
Re: Review Request 62620: Fix binding issues preventing ./gradle run
from working
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62620/#review186456
-----------------------------------------------------------
Ship it!
Master (474320b) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Sept. 27, 2017, 4:06 p.m., Bill Farner wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62620/
> -----------------------------------------------------------
>
> (Updated Sept. 27, 2017, 4:06 p.m.)
>
>
> Review request for Aurora and David McLaughlin.
>
>
> Repository: aurora
>
>
> Description
> -------
>
> A few things going on here:
> - when running `LocalSchedulerMain`, a binding was missing for `@HydrateSnapshotFields Set<String>`
> - `ClusterSimulatorModule` was binding `Set<Offer>` from the `org.apache.mesos.v1` package, but the consumer was using `org.apache.mesos`. Ouch - be on the lookout for this!
> - I added a hack to make guice binding errors less awful. I'd like to work through the tangle of deps to get us to guice 4 soon and make this situation better. [History](https://github.com/google/guice/issues/757) for those interested.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/app/SchedulerMain.java 3fbe99c4f1af1f11403bf08155bb4be028132e38
> src/test/java/org/apache/aurora/scheduler/app/local/LocalSchedulerMain.java 7a342bd82063922ad622237168a4aae76172359f
> src/test/java/org/apache/aurora/scheduler/app/local/simulator/ClusterSimulatorModule.java 963e4dc97845f96554d74df633b49c26341468fa
>
>
> Diff: https://reviews.apache.org/r/62620/diff/2/
>
>
> Testing
> -------
>
> `./gradlew run` works
>
>
> Thanks,
>
> Bill Farner
>
>