You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/28 16:10:38 UTC
[GitHub] [flink] azagrebin commented on a change in pull request #11246:
[FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
azagrebin commented on a change in pull request #11246: [FLINK-16307][e2e] Use start-cluster.sh instead of manually building cluster
URL: https://github.com/apache/flink/pull/11246#discussion_r385777809
##########
File path: flink-end-to-end-tests/flink-end-to-end-tests-common/src/main/java/org/apache/flink/tests/util/flink/LocalStandaloneFlinkResource.java
##########
@@ -71,10 +73,8 @@ public void addConfiguration(final Configuration config) throws IOException {
@Override
public ClusterController startCluster(int numTaskManagers) throws IOException {
- distribution.startJobManager();
- for (int x = 0; x < numTaskManagers; x++) {
- distribution.startTaskManager();
- }
+ distribution.setTaskExecutorHosts(IntStream.range(0, numTaskManagers).mapToObj(i -> "localhost").collect(Collectors.toList()));
Review comment:
```suggestion
distribution.setTaskExecutorHosts(Collections.nCopies(numTaskManagers, "localhost"));
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services