You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2021/03/06 16:11:27 UTC
[GitHub] [tinkerpop] erajabzadeh opened a new pull request #1402: TINKERPOP-2506 Expose WS connection status in JavaScript driver
erajabzadeh opened a new pull request #1402:
URL: https://github.com/apache/tinkerpop/pull/1402
https://issues.apache.org/jira/browse/TINKERPOP-2506
Exposes the underlying WS connection status as a property of the client. Will send a separate PR to update the type definition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1402: TINKERPOP-2506 Expose WS connection status in JavaScript driver
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1402:
URL: https://github.com/apache/tinkerpop/pull/1402#issuecomment-797039022
I can't get the Gremlin Server tests in travis to go green. There is no reason these changes should affect Gremlin Server so I'm not sure what's going on. I'm going to guess it's just Travis being shifty. I will test this locally on merge but for now VOTE +1
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette merged pull request #1402: TINKERPOP-2506 Expose WS connection status in JavaScript driver
Posted by GitBox <gi...@apache.org>.
spmallette merged pull request #1402:
URL: https://github.com/apache/tinkerpop/pull/1402
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1402: TINKERPOP-2506 Expose WS connection status in JavaScript driver
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1402:
URL: https://github.com/apache/tinkerpop/pull/1402#issuecomment-799705169
No problems testing locally - merged. Thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] erajabzadeh commented on pull request #1402: TINKERPOP-2506 Expose WS connection status in JavaScript driver
Posted by GitBox <gi...@apache.org>.
erajabzadeh commented on pull request #1402:
URL: https://github.com/apache/tinkerpop/pull/1402#issuecomment-793998363
Sure thing and thank you.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tinkerpop] spmallette commented on pull request #1402: TINKERPOP-2506 Expose WS connection status in JavaScript driver
Posted by GitBox <gi...@apache.org>.
spmallette commented on pull request #1402:
URL: https://github.com/apache/tinkerpop/pull/1402#issuecomment-793907222
Thank you for this. Could you please clean up the git history a bit and squash this to one commit?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org