You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/03/23 06:37:15 UTC
[GitHub] [spark] viirya opened a new pull request #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
viirya opened a new pull request #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
For now `SHOW CREATE TABLE` command doesn't support views, but `SHOW CREATE TABLE AS SERDE` supports it. Since the views syntax are the same between Hive DDL and Spark DDL, we should be able to support views in both two commands.
This patch proposes to add views support to `SHOW CREATE TABLE`.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To extend the view support of `SHOW CREATE TABLE`, so users can use `SHOW CREATE TABLE` to show Spark DDL for views.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
Yes. `SHOW CREATE TABLE` can be used to show Spark DDL for views.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Unit tests.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609369542
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603358504
**[Test build #120279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120279/testReport)** for PR 27984 at commit [`ac967e9`](https://github.com/apache/spark/commit/ac967e98cc46f0f89704cd30725074cfcf6c96fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603532836
**[Test build #120279 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120279/testReport)** for PR 27984 at commit [`ac967e9`](https://github.com/apache/spark/commit/ac967e98cc46f0f89704cd30725074cfcf6c96fa).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602735748
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#discussion_r399860298
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -1066,6 +1066,35 @@ trait ShowCreateTableCommandBase {
protected def concatByMultiLines(iter: Iterable[String]): String = {
iter.mkString("(\n ", ",\n ", ")\n")
}
+
+ protected def showViewDataColumns(metadata: CatalogTable, builder: StringBuilder): Unit = {
Review comment:
Is this simple move?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#discussion_r403654352
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -1109,21 +1145,33 @@ case class ShowCreateTableCommand(table: TableIdentifier)
)
}
- if (tableMetadata.tableType == VIEW) {
- throw new AnalysisException("Hive view isn't supported by SHOW CREATE TABLE")
- }
-
if ("true".equalsIgnoreCase(tableMetadata.properties.getOrElse("transactional", "false"))) {
throw new AnalysisException(
"SHOW CREATE TABLE doesn't support transactional Hive table. " +
s"Please use `SHOW CREATE TABLE ${tableMetadata.identifier} AS SERDE` " +
"to show Hive DDL instead.")
}
- convertTableMetadata(tableMetadata)
+ if (tableMetadata.tableType == VIEW) {
Review comment:
We need the check of unsupported feature like `partitioned view` in this branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609364882
**[Test build #120831 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120831/testReport)** for PR 27984 at commit [`920be2c`](https://github.com/apache/spark/commit/920be2c1e20ec5bbddee96b7618bc17166e23b84).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603534178
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120279/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602414660
**[Test build #120180 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120180/testReport)** for PR 27984 at commit [`b49db3b`](https://github.com/apache/spark/commit/b49db3b939e918680639b8ef30fb7fdf533e3578).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609369512
**[Test build #120830 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120830/testReport)** for PR 27984 at commit [`8277e31`](https://github.com/apache/spark/commit/8277e31412f2a2e53bbd62bffc6e3460637bd00d).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602997008
**[Test build #120236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120236/testReport)** for PR 27984 at commit [`ac967e9`](https://github.com/apache/spark/commit/ac967e98cc46f0f89704cd30725074cfcf6c96fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602415062
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603359312
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602415068
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24893/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603359325
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24989/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
viirya commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602996461
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602997442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24949/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602421505
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120180/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602866253
**[Test build #120211 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120211/testReport)** for PR 27984 at commit [`ac967e9`](https://github.com/apache/spark/commit/ac967e98cc46f0f89704cd30725074cfcf6c96fa).
* This patch **fails PySpark pip packaging tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603206686
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120253/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602424433
**[Test build #120181 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120181/testReport)** for PR 27984 at commit [`b49db3b`](https://github.com/apache/spark/commit/b49db3b939e918680639b8ef30fb7fdf533e3578).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602526307
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120181/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603079927
**[Test build #120253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120253/testReport)** for PR 27984 at commit [`ac967e9`](https://github.com/apache/spark/commit/ac967e98cc46f0f89704cd30725074cfcf6c96fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609375419
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25531/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603065160
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609375418
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603065160
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602734990
**[Test build #120211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120211/testReport)** for PR 27984 at commit [`ac967e9`](https://github.com/apache/spark/commit/ac967e98cc46f0f89704cd30725074cfcf6c96fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-608405428
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602424886
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-608405434
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120761/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609407733
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602414660
**[Test build #120180 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120180/testReport)** for PR 27984 at commit [`b49db3b`](https://github.com/apache/spark/commit/b49db3b939e918680639b8ef30fb7fdf533e3578).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609364347
**[Test build #120830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120830/testReport)** for PR 27984 at commit [`8277e31`](https://github.com/apache/spark/commit/8277e31412f2a2e53bbd62bffc6e3460637bd00d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-608279081
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603077282
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602867157
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602735763
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24924/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603065172
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120236/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-608279081
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603077293
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24964/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
viirya commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603535360
cc @cloud-fan @dongjoon-hyun @HyukjinKwon
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609369544
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603206677
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602526307
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120181/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602735763
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24924/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603206268
**[Test build #120253 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120253/testReport)** for PR 27984 at commit [`ac967e9`](https://github.com/apache/spark/commit/ac967e98cc46f0f89704cd30725074cfcf6c96fa).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-608405428
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602421505
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120180/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609369549
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120831/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-608278526
**[Test build #120761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120761/testReport)** for PR 27984 at commit [`920be2c`](https://github.com/apache/spark/commit/920be2c1e20ec5bbddee96b7618bc17166e23b84).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609369511
**[Test build #120831 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120831/testReport)** for PR 27984 at commit [`920be2c`](https://github.com/apache/spark/commit/920be2c1e20ec5bbddee96b7618bc17166e23b84).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609407735
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120834/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
viirya commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603353795
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609407735
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120834/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603077293
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24964/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602421497
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603206686
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120253/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
viirya commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603076913
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#discussion_r399860298
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -1066,6 +1066,35 @@ trait ShowCreateTableCommandBase {
protected def concatByMultiLines(iter: Iterable[String]): String = {
iter.mkString("(\n ", ",\n ", ")\n")
}
+
+ protected def showViewDataColumns(metadata: CatalogTable, builder: StringBuilder): Unit = {
Review comment:
Is this simple move to reuse?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602415068
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24893/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
viirya commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602423879
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602997434
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#discussion_r402781771
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -1066,6 +1066,35 @@ trait ShowCreateTableCommandBase {
protected def concatByMultiLines(iter: Iterable[String]): String = {
iter.mkString("(\n ", ",\n ", ")\n")
}
+
+ protected def showViewDataColumns(metadata: CatalogTable, builder: StringBuilder): Unit = {
Review comment:
Yes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609369545
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120830/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603534171
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602867166
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120211/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602525817
**[Test build #120181 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120181/testReport)** for PR 27984 at commit [`b49db3b`](https://github.com/apache/spark/commit/b49db3b939e918680639b8ef30fb7fdf533e3578).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603206677
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603079927
**[Test build #120253 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120253/testReport)** for PR 27984 at commit [`ac967e9`](https://github.com/apache/spark/commit/ac967e98cc46f0f89704cd30725074cfcf6c96fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609364882
**[Test build #120831 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120831/testReport)** for PR 27984 at commit [`920be2c`](https://github.com/apache/spark/commit/920be2c1e20ec5bbddee96b7618bc17166e23b84).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609407733
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602997434
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603358504
**[Test build #120279 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120279/testReport)** for PR 27984 at commit [`ac967e9`](https://github.com/apache/spark/commit/ac967e98cc46f0f89704cd30725074cfcf6c96fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#discussion_r403838572
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -1109,21 +1145,33 @@ case class ShowCreateTableCommand(table: TableIdentifier)
)
}
- if (tableMetadata.tableType == VIEW) {
- throw new AnalysisException("Hive view isn't supported by SHOW CREATE TABLE")
- }
-
if ("true".equalsIgnoreCase(tableMetadata.properties.getOrElse("transactional", "false"))) {
throw new AnalysisException(
"SHOW CREATE TABLE doesn't support transactional Hive table. " +
s"Please use `SHOW CREATE TABLE ${tableMetadata.identifier} AS SERDE` " +
"to show Hive DDL instead.")
}
- convertTableMetadata(tableMetadata)
+ if (tableMetadata.tableType == VIEW) {
Review comment:
ah makes sense
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602421424
**[Test build #120180 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120180/testReport)** for PR 27984 at commit [`b49db3b`](https://github.com/apache/spark/commit/b49db3b939e918680639b8ef30fb7fdf533e3578).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602867157
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-608405434
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120761/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602424893
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24894/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609574778
thanks, merging to master/3.0!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603065172
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120236/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609375419
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25531/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602526299
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602734990
**[Test build #120211 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120211/testReport)** for PR 27984 at commit [`ac967e9`](https://github.com/apache/spark/commit/ac967e98cc46f0f89704cd30725074cfcf6c96fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#discussion_r403654352
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -1109,21 +1145,33 @@ case class ShowCreateTableCommand(table: TableIdentifier)
)
}
- if (tableMetadata.tableType == VIEW) {
- throw new AnalysisException("Hive view isn't supported by SHOW CREATE TABLE")
- }
-
if ("true".equalsIgnoreCase(tableMetadata.properties.getOrElse("transactional", "false"))) {
throw new AnalysisException(
"SHOW CREATE TABLE doesn't support transactional Hive table. " +
s"Please use `SHOW CREATE TABLE ${tableMetadata.identifier} AS SERDE` " +
"to show Hive DDL instead.")
}
- convertTableMetadata(tableMetadata)
+ if (tableMetadata.tableType == VIEW) {
Review comment:
We need to check for unsupported feature like `partitioned view` in this branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609369549
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120831/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609376046
**[Test build #120834 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120834/testReport)** for PR 27984 at commit [`920be2c`](https://github.com/apache/spark/commit/920be2c1e20ec5bbddee96b7618bc17166e23b84).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#discussion_r402787823
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -1109,21 +1138,37 @@ case class ShowCreateTableCommand(table: TableIdentifier)
)
}
- if (tableMetadata.tableType == VIEW) {
- throw new AnalysisException("Hive view isn't supported by SHOW CREATE TABLE")
- }
-
if ("true".equalsIgnoreCase(tableMetadata.properties.getOrElse("transactional", "false"))) {
throw new AnalysisException(
"SHOW CREATE TABLE doesn't support transactional Hive table. " +
s"Please use `SHOW CREATE TABLE ${tableMetadata.identifier} AS SERDE` " +
"to show Hive DDL instead.")
}
- convertTableMetadata(tableMetadata)
+ if (tableMetadata.tableType == VIEW) {
+ tableMetadata
+ } else {
+ convertTableMetadata(tableMetadata)
+ }
}
- val stmt = showCreateDataSourceTable(metadata)
+ val builder = StringBuilder.newBuilder
+
+ val stmt = if (tableMetadata.tableType == VIEW) {
Review comment:
Created a method like suggestion.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609364347
**[Test build #120830 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120830/testReport)** for PR 27984 at commit [`8277e31`](https://github.com/apache/spark/commit/8277e31412f2a2e53bbd62bffc6e3460637bd00d).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609369544
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603077282
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602997442
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24949/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603534178
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120279/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602424893
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24894/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602867166
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120211/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#discussion_r397697683
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -1109,21 +1138,37 @@ case class ShowCreateTableCommand(table: TableIdentifier)
)
}
- if (tableMetadata.tableType == VIEW) {
- throw new AnalysisException("Hive view isn't supported by SHOW CREATE TABLE")
- }
-
if ("true".equalsIgnoreCase(tableMetadata.properties.getOrElse("transactional", "false"))) {
throw new AnalysisException(
"SHOW CREATE TABLE doesn't support transactional Hive table. " +
s"Please use `SHOW CREATE TABLE ${tableMetadata.identifier} AS SERDE` " +
"to show Hive DDL instead.")
}
- convertTableMetadata(tableMetadata)
+ if (tableMetadata.tableType == VIEW) {
+ tableMetadata
+ } else {
+ convertTableMetadata(tableMetadata)
+ }
}
- val stmt = showCreateDataSourceTable(metadata)
+ val builder = StringBuilder.newBuilder
+
+ val stmt = if (tableMetadata.tableType == VIEW) {
Review comment:
can we create a method to generate `CREATE VIEW`? So we can just call one method in the `if` branch.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-608278526
**[Test build #120761 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120761/testReport)** for PR 27984 at commit [`920be2c`](https://github.com/apache/spark/commit/920be2c1e20ec5bbddee96b7618bc17166e23b84).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602424433
**[Test build #120181 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120181/testReport)** for PR 27984 at commit [`b49db3b`](https://github.com/apache/spark/commit/b49db3b939e918680639b8ef30fb7fdf533e3578).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603359312
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603064800
**[Test build #120236 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120236/testReport)** for PR 27984 at commit [`ac967e9`](https://github.com/apache/spark/commit/ac967e98cc46f0f89704cd30725074cfcf6c96fa).
* This patch **fails due to an unknown error code, -9**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-608404638
**[Test build #120761 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120761/testReport)** for PR 27984 at commit [`920be2c`](https://github.com/apache/spark/commit/920be2c1e20ec5bbddee96b7618bc17166e23b84).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602424886
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-608279089
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25461/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-608279089
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/25461/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609407464
**[Test build #120834 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120834/testReport)** for PR 27984 at commit [`920be2c`](https://github.com/apache/spark/commit/920be2c1e20ec5bbddee96b7618bc17166e23b84).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609369545
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/120830/
Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609369542
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#discussion_r399860530
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -1109,21 +1138,37 @@ case class ShowCreateTableCommand(table: TableIdentifier)
)
}
- if (tableMetadata.tableType == VIEW) {
- throw new AnalysisException("Hive view isn't supported by SHOW CREATE TABLE")
- }
-
if ("true".equalsIgnoreCase(tableMetadata.properties.getOrElse("transactional", "false"))) {
throw new AnalysisException(
"SHOW CREATE TABLE doesn't support transactional Hive table. " +
s"Please use `SHOW CREATE TABLE ${tableMetadata.identifier} AS SERDE` " +
"to show Hive DDL instead.")
}
- convertTableMetadata(tableMetadata)
+ if (tableMetadata.tableType == VIEW) {
+ tableMetadata
+ } else {
+ convertTableMetadata(tableMetadata)
+ }
}
- val stmt = showCreateDataSourceTable(metadata)
+ val builder = StringBuilder.newBuilder
+
+ val stmt = if (tableMetadata.tableType == VIEW) {
Review comment:
+1 for @cloud-fan 's advice. We had better have a function similar to `showCreateDataSourceTable`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603359325
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/24989/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609376046
**[Test build #120834 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120834/testReport)** for PR 27984 at commit [`920be2c`](https://github.com/apache/spark/commit/920be2c1e20ec5bbddee96b7618bc17166e23b84).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602526299
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#discussion_r402823718
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/command/tables.scala
##########
@@ -1109,21 +1145,33 @@ case class ShowCreateTableCommand(table: TableIdentifier)
)
}
- if (tableMetadata.tableType == VIEW) {
- throw new AnalysisException("Hive view isn't supported by SHOW CREATE TABLE")
- }
-
if ("true".equalsIgnoreCase(tableMetadata.properties.getOrElse("transactional", "false"))) {
throw new AnalysisException(
"SHOW CREATE TABLE doesn't support transactional Hive table. " +
s"Please use `SHOW CREATE TABLE ${tableMetadata.identifier} AS SERDE` " +
"to show Hive DDL instead.")
}
- convertTableMetadata(tableMetadata)
+ if (tableMetadata.tableType == VIEW) {
Review comment:
I think we should put it in a higher level
```
val metadata = if (DDLUtils.isDatasourceTable(tableMetadata) || tableMetadata.tableType == VIEW) {
tableMetadata
} else {
...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609375418
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #27984:
[SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-603534171
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602421497
Merged build finished. Test FAILed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602735748
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #27984: [SPARK-31224][SQL]
Add view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602415062
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-602997008
**[Test build #120236 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/120236/testReport)** for PR 27984 at commit [`ac967e9`](https://github.com/apache/spark/commit/ac967e98cc46f0f89704cd30725074cfcf6c96fa).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on issue #27984: [SPARK-31224][SQL] Add
view support to SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
viirya commented on issue #27984: [SPARK-31224][SQL] Add view support to SHOW CREATE TABLE
URL: https://github.com/apache/spark/pull/27984#issuecomment-609375296
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org