You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "slawekjaranowski (via GitHub)" <gi...@apache.org> on 2025/01/11 15:55:16 UTC
[PR] Add priority labels [maven-gh-actions-shared]
slawekjaranowski opened a new pull request, #129:
URL: https://github.com/apache/maven-gh-actions-shared/pull/129
Name, description and color from jira for easy mapping.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add priority labels [maven-gh-actions-shared]
Posted by "slachiewicz (via GitHub)" <gi...@apache.org>.
slachiewicz commented on code in PR #129:
URL: https://github.com/apache/maven-gh-actions-shared/pull/129#discussion_r1912479619
##########
.github/labels.js:
##########
@@ -66,6 +66,31 @@ module.exports = [
color: "912E29",
description: ""
},
+ {
+ name: "priority:blocker",
+ color: "cc0000",
+ description: "Blocks development and/or testing work, production could not run"
+ },
+ {
+ name: "priority:critical",
+ color: "ff0000",
+ description: "Crashes, loss of data, severe memory leak"
Review Comment:
Good point. We should add somewhere that users should not report security issues via Issues but report it via official ASF channels. Optionally we may enable GitHub feature for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add priority labels [maven-gh-actions-shared]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #129:
URL: https://github.com/apache/maven-gh-actions-shared/pull/129#discussion_r1912482061
##########
.github/labels.js:
##########
@@ -66,6 +66,31 @@ module.exports = [
color: "912E29",
description: ""
},
+ {
+ name: "priority:blocker",
+ color: "cc0000",
+ description: "Blocks development and/or testing work, production could not run"
+ },
+ {
+ name: "priority:critical",
+ color: "ff0000",
+ description: "Crashes, loss of data, severe memory leak"
+ },
+ {
+ name: "priority:major",
+ color: "009900",
+ description: "Major loss of function"
+ },
+ {
+ name: "priority:minor",
+ color: "006600",
+ description: "Minor loss of function, or other problem where easy workaround is present"
+ },
+ {
+ name: "priority:trivial",
+ color: "003300",
+ description: "Cosmetic problem like misspell words or misaligned text"
Review Comment:
misspell --> misspelled
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add priority labels [maven-gh-actions-shared]
Posted by "elharo (via GitHub)" <gi...@apache.org>.
elharo commented on code in PR #129:
URL: https://github.com/apache/maven-gh-actions-shared/pull/129#discussion_r1912182705
##########
.github/labels.js:
##########
@@ -66,6 +66,31 @@ module.exports = [
color: "912E29",
description: ""
},
+ {
+ name: "priority:blocker",
+ color: "cc0000",
+ description: "Blocks development and/or testing work, production could not run"
+ },
+ {
+ name: "priority:critical",
+ color: "ff0000",
+ description: "Crashes, loss of data, severe memory leak"
Review Comment:
Add security holes?
##########
.github/labels.js:
##########
@@ -66,6 +66,31 @@ module.exports = [
color: "912E29",
description: ""
},
+ {
+ name: "priority:blocker",
+ color: "cc0000",
+ description: "Blocks development and/or testing work, production could not run"
+ },
+ {
+ name: "priority:critical",
+ color: "ff0000",
+ description: "Crashes, loss of data, severe memory leak"
+ },
+ {
+ name: "priority:major",
+ color: "009900",
+ description: "Major loss of function"
+ },
+ {
+ name: "priority:minor",
+ color: "006600",
+ description: "Minor loss of function, or other problem where easy workaround is present"
+ },
+ {
+ name: "priority:trivial",
+ color: "003300",
+ description: "Cosmetic problem like misspell words or misaligned text"
Review Comment:
misspelled
##########
.github/labels.js:
##########
@@ -66,6 +66,31 @@ module.exports = [
color: "912E29",
description: ""
},
+ {
+ name: "priority:blocker",
+ color: "cc0000",
+ description: "Blocks development and/or testing work, production could not run"
Review Comment:
Hmm, I've been interpreting this as blocks release. That is, don't release before this is fixed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add priority labels [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #129:
URL: https://github.com/apache/maven-gh-actions-shared/pull/129#discussion_r1912502456
##########
.github/labels.js:
##########
@@ -66,6 +66,31 @@ module.exports = [
color: "912E29",
description: ""
},
+ {
+ name: "priority:blocker",
+ color: "cc0000",
+ description: "Blocks development and/or testing work, production could not run"
+ },
+ {
+ name: "priority:critical",
+ color: "ff0000",
+ description: "Crashes, loss of data, severe memory leak"
+ },
+ {
+ name: "priority:major",
+ color: "009900",
+ description: "Major loss of function"
+ },
+ {
+ name: "priority:minor",
+ color: "006600",
+ description: "Minor loss of function, or other problem where easy workaround is present"
+ },
+ {
+ name: "priority:trivial",
+ color: "003300",
+ description: "Cosmetic problem like misspell words or misaligned text"
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add priority labels [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #129:
URL: https://github.com/apache/maven-gh-actions-shared/pull/129#issuecomment-2585311134
@sparsick please also look
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add priority labels [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on PR #129:
URL: https://github.com/apache/maven-gh-actions-shared/pull/129#issuecomment-2585849335
I have copied from JIRA to have similar in GitHub
https://issues.apache.org/jira/plugins/servlet/project-config/MNG/priorities (visible for PMC)
<img width="1422" alt="image" src="https://github.com/user-attachments/assets/f543d4a3-281d-45ed-b987-8c573a1ad37e" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add priority labels [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski merged PR #129:
URL: https://github.com/apache/maven-gh-actions-shared/pull/129
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add priority labels [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #129:
URL: https://github.com/apache/maven-gh-actions-shared/pull/129#discussion_r1912501699
##########
.github/labels.js:
##########
@@ -66,6 +66,31 @@ module.exports = [
color: "912E29",
description: ""
},
+ {
+ name: "priority:blocker",
+ color: "cc0000",
+ description: "Blocks development and/or testing work, production could not run"
Review Comment:
Yes you think in good way, we have:
> check existing issues with Blocker priority, consider to fix it or change priority if reasonable
https://maven.apache.org/developers/release/maven-project-release-procedure.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add priority labels [maven-gh-actions-shared]
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #129:
URL: https://github.com/apache/maven-gh-actions-shared/pull/129#discussion_r1912502155
##########
.github/labels.js:
##########
@@ -66,6 +66,31 @@ module.exports = [
color: "912E29",
description: ""
},
+ {
+ name: "priority:blocker",
+ color: "cc0000",
+ description: "Blocks development and/or testing work, production could not run"
+ },
+ {
+ name: "priority:critical",
+ color: "ff0000",
+ description: "Crashes, loss of data, severe memory leak"
Review Comment:
We have it out of the box with GitHug issues - https://github.com/apache/maven-gh-actions-shared/issues/new/choose
<img width="1171" alt="image" src="https://github.com/user-attachments/assets/b677e07d-773c-493c-92b0-56cac3ebe484" />
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Add priority labels [maven-gh-actions-shared]
Posted by "Bukama (via GitHub)" <gi...@apache.org>.
Bukama commented on PR #129:
URL: https://github.com/apache/maven-gh-actions-shared/pull/129#issuecomment-2587680070
> The definitions here are more what I would call Severity than Priority. There are bug tracking systems and projects that make a distinction between the two (e.g. Google's Buganizer) though I recognize this approach is not universal.
This was also my thought when I've read the description of the labels, which are all focus on bugs, but don't take features/improvements into account. Can be please add severity labels too to be more specific on bugs?
Classic examples for the difference are:
* An error which crashes the systems, but happens only under very special circumstances. This can/will have a severity of "high/critical", because the system crashes. On the other side the priority might be low, because occurs only rarely.
* A spelling/grammar mistake on the invoice: Severity low (functionality is not affected), but high priority, because it's visible on every customers invoice.
P.S. I know that priority is a thing that often does not get maintained, as those may change over time. We have to see how this works out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org