[GitHub] [beam] potiuk commented on a change in pull request #14328: Update mock version

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #14328:
URL: https://github.com/apache/beam/pull/14328#discussion_r602701217



##########
File path: sdks/python/setup.py
##########
@@ -146,7 +146,7 @@ def get_version():
     'grpcio>=1.29.0,<2',
     'hdfs>=2.1.0,<3.0.0',
     'httplib2>=0.8,<0.18.0',
-    'mock>=1.0.1,<3.0.0',

Review comment:
       That would also help us enormously in Apache Airflow . Currently `apache-beam` package is the only package excluded from installation on our CI because it has the mock and dill dependency pinned to very old versions:
   
   https://github.com/apache/airflow/blob/master/setup.py#L743
   
   ```
   # Those packages are excluded because they break tests and they are not needed to run our test suite.
   # This can be removed as soon as we get non-conflicting
   # requirements for the apache-beam as well.
   #
   # Currently Apache Beam has very narrow and old dependencies for 'dill' and 'mock' packages which
   # are required by our tests (but only for tests).
   #
   PACKAGES_EXCLUDED_FOR_CI = [
       'apache-beam',
   ]
   ```
   
   I think dill is not a problem (we only use it with beam tests and 0.3.3 is anyhow the latest available version), but moving mock to test packages would help enormously.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org