You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@orc.apache.org by stiga-huang <gi...@git.apache.org> on 2018/03/03 09:27:41 UTC
[GitHub] orc pull request #225: ORC-313: Check subtype count in converting protobuf T...
GitHub user stiga-huang opened a pull request:
https://github.com/apache/orc/pull/225
ORC-313: Check subtype count in converting protobuf Types
We need to verify the subtype count of LIST and MAP types. Otherwise,
the ill types will lead the c++ reader to crash.
The java reader also has this problem.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/stiga-huang/orc check-subtypes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/orc/pull/225.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #225
----
commit 8d7a668e6cc7025f4078ddcd9178a4d759d386f5
Author: stiga-huang <hu...@...>
Date: 2018-03-03T09:21:23Z
ORC-313: Check subtype count in converting protobuf Types
We need to verify the subtype count of LIST and MAP types. Otherwise,
the ill types will lead the c++ reader to crash.
The java reader also has this problem.
----
---
[GitHub] orc issue #225: ORC-313,ORC-317: Check types in footer
Posted by stiga-huang <gi...@git.apache.org>.
Github user stiga-huang commented on the issue:
https://github.com/apache/orc/pull/225
@majetideepak To be clean, I open #231 for ORC-317. I'd like to close this PR. Thanks for your review!
---
[GitHub] orc issue #225: ORC-313,ORC-317: Check types in footer
Posted by stiga-huang <gi...@git.apache.org>.
Github user stiga-huang commented on the issue:
https://github.com/apache/orc/pull/225
@majetideepak I opened #229 for ORC-313
---
[GitHub] orc issue #225: ORC-313,ORC-317: Check types in footer
Posted by majetideepak <gi...@git.apache.org>.
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/225
@stiga-huang I will look into these this week. Can you fix the title of this PR? Thanks!
---
[GitHub] orc issue #225: ORC-313: Check subtype count in converting protobuf Types
Posted by stiga-huang <gi...@git.apache.org>.
Github user stiga-huang commented on the issue:
https://github.com/apache/orc/pull/225
With the bug of ORC-317, I think we can check the protobuf Types at the end of orc::readFooter for
- ORC-313: check the subtype count of LIST and MAP
- ORC-317: check that the type tree is valid (not containing loop)
Will update this PR later.
---
[GitHub] orc issue #225: ORC-313,ORC-317: Check types in footer
Posted by majetideepak <gi...@git.apache.org>.
Github user majetideepak commented on the issue:
https://github.com/apache/orc/pull/225
@stiga-huang can you open a separate PR or each JIRA? Thanks.
---
[GitHub] orc issue #225: ORC-313,ORC-317: Check types in footer
Posted by stiga-huang <gi...@git.apache.org>.
Github user stiga-huang commented on the issue:
https://github.com/apache/orc/pull/225
Hi @omalley @majetideepak, this PR is ready for review. Could you have a look?
---
[GitHub] orc issue #225: ORC-313,ORC-317: Check types in footer
Posted by stiga-huang <gi...@git.apache.org>.
Github user stiga-huang commented on the issue:
https://github.com/apache/orc/pull/225
@majetideepak OK. When I separate the PR, I found orc-test failed in TestWriter.writeTimestamp (ORC-320). I might need to fix that first.
---
[GitHub] orc pull request #225: ORC-313,ORC-317: Check types in footer
Posted by stiga-huang <gi...@git.apache.org>.
Github user stiga-huang closed the pull request at:
https://github.com/apache/orc/pull/225
---