[GitHub] [iceberg] rdblue commented on a change in pull request #4005: Core: Add delete file details for PartitionsTable

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #4005:
URL: https://github.com/apache/iceberg/pull/4005#discussion_r810674633



##########
File path: core/src/main/java/org/apache/iceberg/PartitionsTable.java
##########
@@ -167,16 +175,30 @@ Partition get(StructLike key) {
     private final StructLike key;
     private long recordCount;
     private int fileCount;
+    private int deleteFileCount;
+    private long equalityDeleteCount;
+    private long positionDeleteCount;
 
     Partition(StructLike key) {
       this.key = key;
       this.recordCount = 0;
       this.fileCount = 0;
+      this.deleteFileCount = 0;
+      this.equalityDeleteCount = 0L;
+      this.positionDeleteCount = 0L;
     }
 
-    void update(DataFile file) {
-      this.recordCount += file.recordCount();
+    void update(FileScanTask task) {
+      this.recordCount += task.file().recordCount();
       this.fileCount += 1;
+      this.deleteFileCount += task.deletes().size();

Review comment:
       +1 to this. This could definitely have duplicates!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org