You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by le...@apache.org on 2020/10/23 15:40:03 UTC
svn commit: r1882784 -
/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CharStringHandler.java
Author: lehmi
Date: Fri Oct 23 15:40:03 2020
New Revision: 1882784
URL: http://svn.apache.org/viewvc?rev=1882784&view=rev
Log:
PDFBOX-4892: replace Stack with ArrayList, remove unused return value
Modified:
pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CharStringHandler.java
Modified: pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CharStringHandler.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CharStringHandler.java?rev=1882784&r1=1882783&r2=1882784&view=diff
==============================================================================
--- pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CharStringHandler.java (original)
+++ pdfbox/trunk/fontbox/src/main/java/org/apache/fontbox/cff/CharStringHandler.java Fri Oct 23 15:40:03 2020
@@ -16,9 +16,8 @@
*/
package org.apache.fontbox.cff;
-
+import java.util.ArrayList;
import java.util.List;
-import java.util.Stack;
/**
* A Handler for CharStringCommands.
@@ -36,23 +35,22 @@ public interface CharStringHandler
* @param sequence of CharStringCommands
*
*/
- default List<Number> handleSequence(List<Object> sequence)
+ default void handleSequence(List<Object> sequence)
{
- Stack<Number> stack = new Stack<>();
+ List<Number> numbers = new ArrayList<>();
sequence.forEach(obj ->
{
if (obj instanceof CharStringCommand)
{
- List<Number> results = handleCommand(stack, (CharStringCommand) obj);
- stack.clear(); // this is basically returning the new stack
- stack.addAll(results);
+ List<Number> results = handleCommand(numbers, (CharStringCommand) obj);
+ numbers.clear();
+ numbers.addAll(results);
}
else
{
- stack.push((Number) obj);
+ numbers.add((Number) obj);
}
});
- return stack;
}
/**