You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/11/08 11:35:29 UTC
[GitHub] [dubbo-go] Mulavar opened a new pull request #1576: [#1573]fix the nacos namespace from server/client.yml does not take e…
Mulavar opened a new pull request #1576:
URL: https://github.com/apache/dubbo-go/pull/1576
…ffect
<!-- Thanks for sending a pull request!
Read https://github.com/apache/dubbo-go/blob/master/CONTRIBUTING.md before commit pull request.
-->
**What this PR does**:
**Which issue(s) this PR fixes**:
<!--
*Automatically closes linked issue when PR is merged.
Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`.
_If PR is about `failing-tests or flakes`, please post the related issues/tests in a comment and do not use `Fixes`_*
-->
Fixes #
**Special notes for your reviewer**:
**Does this PR introduce a user-facing change?**:
<!--
If no, just write "NONE" in the release-note block below.
If yes, a release note is required:
Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required".
-->
```release-note
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zhaoyunxing92 merged pull request #1576: [#1573]1.5 fix the nacos namespace from server/client.yml does not take e…
Posted by GitBox <gi...@apache.org>.
zhaoyunxing92 merged pull request #1576:
URL: https://github.com/apache/dubbo-go/pull/1576
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-commenter commented on pull request #1576: [#1573]1.5 fix the nacos namespace from server/client.yml does not take e…
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1576:
URL: https://github.com/apache/dubbo-go/pull/1576#issuecomment-963788374
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1576?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1576](https://codecov.io/gh/apache/dubbo-go/pull/1576?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e785d0d) into [1.5](https://codecov.io/gh/apache/dubbo-go/commit/a4b4f50aa23b06e59c7945054b5bf9c56718a76d?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (a4b4f50) will **increase** coverage by `0.02%`.
> The diff coverage is `54.16%`.
> :exclamation: Current head e785d0d differs from pull request most recent head 2cb57ab. Consider uploading reports for the commit 2cb57ab to get more accurate results
[](https://codecov.io/gh/apache/dubbo-go/pull/1576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 1.5 #1576 +/- ##
==========================================
+ Coverage 55.72% 55.75% +0.02%
==========================================
Files 279 279
Lines 16024 16072 +48
==========================================
+ Hits 8930 8961 +31
- Misses 6153 6167 +14
- Partials 941 944 +3
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/1576?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [common/logger/logger.go](https://codecov.io/gh/apache/dubbo-go/pull/1576/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnZXIuZ28=) | `92.75% <ø> (ø)` | |
| [common/logger/logging.go](https://codecov.io/gh/apache/dubbo-go/pull/1576/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29tbW9uL2xvZ2dlci9sb2dnaW5nLmdv) | `80.00% <0.00%> (-20.00%)` | :arrow_down: |
| [config/config\_center\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1576/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbmZpZ19jZW50ZXJfY29uZmlnLmdv) | `66.21% <ø> (+5.19%)` | :arrow_up: |
| [config/consumer\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1576/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL2NvbnN1bWVyX2NvbmZpZy5nbw==) | `58.69% <ø> (ø)` | |
| [config/protocol\_config.go](https://codecov.io/gh/apache/dubbo-go/pull/1576/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-Y29uZmlnL3Byb3RvY29sX2NvbmZpZy5nbw==) | `100.00% <ø> (ø)` | |
| [protocol/dubbo/impl/package.go](https://codecov.io/gh/apache/dubbo-go/pull/1576/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9wYWNrYWdlLmdv) | `62.06% <ø> (ø)` | |
| [protocol/invocation/rpcinvocation.go](https://codecov.io/gh/apache/dubbo-go/pull/1576/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvaW52b2NhdGlvbi9ycGNpbnZvY2F0aW9uLmdv) | `16.66% <0.00%> (-0.61%)` | :arrow_down: |
| [registry/service\_instance.go](https://codecov.io/gh/apache/dubbo-go/pull/1576/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvc2VydmljZV9pbnN0YW5jZS5nbw==) | `0.00% <ø> (ø)` | |
| [protocol/dubbo/impl/codec.go](https://codecov.io/gh/apache/dubbo-go/pull/1576/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJvdG9jb2wvZHViYm8vaW1wbC9jb2RlYy5nbw==) | `41.50% <20.00%> (-0.16%)` | :arrow_down: |
| [registry/nacos/registry.go](https://codecov.io/gh/apache/dubbo-go/pull/1576/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cmVnaXN0cnkvbmFjb3MvcmVnaXN0cnkuZ28=) | `43.84% <40.00%> (-0.51%)` | :arrow_down: |
| ... and [12 more](https://codecov.io/gh/apache/dubbo-go/pull/1576/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1576?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/1576?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [22ec982...2cb57ab](https://codecov.io/gh/apache/dubbo-go/pull/1576?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] Mulavar commented on a change in pull request #1576: [#1573]1.5 fix the nacos namespace from server/client.yml does not take e…
Posted by GitBox <gi...@apache.org>.
Mulavar commented on a change in pull request #1576:
URL: https://github.com/apache/dubbo-go/pull/1576#discussion_r745266895
##########
File path: config_center/dynamic_configuration.go
##########
@@ -34,10 +34,10 @@ import (
// DynamicConfiguration
// ////////////////////////////////////////
const (
- // DEFAULT_GROUP: default group
+ // DEFAULT_GROUP default group
Review comment:
不删除原有常量是发现有其他地方在用（apollo、file），尚不清楚这两个的具体实现，因此为了避免歧义新增了常量。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org