You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "andreydevyatkin (via GitHub)" <gi...@apache.org> on 2023/09/11 09:49:07 UTC
[GitHub] [beam] andreydevyatkin opened a new pull request, #28390: Migrate "beam_PostCommit_Java_ValidatesRunner_*" Jenkins jobs to GitHub Actions
andreydevyatkin opened a new pull request, #28390:
URL: https://github.com/apache/beam/pull/28390
The following jenkins jobs have been migrated:
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java17/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Streaming/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_V2_Streaming/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_V2/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Direct_Java11/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Direct_Java17/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Direct/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Java11/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/
- https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_ULR/
### How has it been tested?
The job has been tested on Self-hosted GKE runners ubuntu 20.04.
The following test cases are passed:
- by manually running the job (`workflow_dispatch`)
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://github.com/apache/beam/blob/master/CONTRIBUTING.md#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI or the [workflows README](https://github.com/apache/beam/blob/master/.github/workflows/README.md) to see a list of phrases to trigger workflows.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andreydevyatkin commented on a diff in pull request #28390: Migrate "beam_PostCommit_Java_ValidatesRunner_*" Jenkins jobs to GitHub Actions
Posted by "andreydevyatkin (via GitHub)" <gi...@apache.org>.
andreydevyatkin commented on code in PR #28390:
URL: https://github.com/apache/beam/pull/28390#discussion_r1326193300
##########
.github/workflows/beam_PostCommit_Java_ValidatesRunner_Dataflow_V2.yml:
##########
@@ -0,0 +1,94 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PostCommit Java ValidatesRunner Dataflow V2
+
+on:
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
Review Comment:
Good catch! Bumped to 8 hrs and double checked for other jobs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #28390: Migrate "beam_PostCommit_Java_ValidatesRunner_*" Jenkins jobs to GitHub Actions
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #28390:
URL: https://github.com/apache/beam/pull/28390#discussion_r1326075889
##########
.github/workflows/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java.yml:
##########
@@ -0,0 +1,114 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PostCommit Java ValidatesRunner Dataflow Java
+
+on:
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
Review Comment:
let's monitor how this schedule leads to. On Jenkiins the if the second job triggered and the first one not finished, it will be queued until the first one finish / or time out; here it will cancel the previous one. If that happens consider bumping all dataflow validrunner schedule to every 8 hr (or more)
##########
.github/workflows/beam_PostCommit_Java_ValidatesRunner_Direct_Java.yml:
##########
@@ -0,0 +1,109 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PostCommit Java ValidatesRunner Direct Java
+
+on:
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.body || github.event.sender.login}}'
+ cancel-in-progress: true
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: write
+ checks: write
+ contents: read
+ deployments: read
+ id-token: none
+ issues: write
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+jobs:
+ beam_PostCommit_Java_ValidatesRunner_Direct_Java:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}} ${{matrix.java_version}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 480
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_PostCommit_Java_ValidatesRunner_Direct_Java]
Review Comment:
Consider suffix `Java` -> `JavaVersions` ? (Similar to FlinkVersions / SparkVersions we used for workflows with a matrix) - and same as other workflows having Java11/Java17
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] codecov[bot] commented on pull request #28390: Migrate "beam_PostCommit_Java_ValidatesRunner_*" Jenkins jobs to GitHub Actions
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #28390:
URL: https://github.com/apache/beam/pull/28390#issuecomment-1719870961
## [Codecov](https://app.codecov.io/gh/apache/beam/pull/28390?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#28390](https://app.codecov.io/gh/apache/beam/pull/28390?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (dfe1688) into [master](https://app.codecov.io/gh/apache/beam/commit/5696c59f224949e390b0a72ec80e47c0c9bf1bda?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (5696c59) will **decrease** coverage by `0.02%`.
> Report is 3 commits behind head on master.
> The diff coverage is `44.00%`.
> :exclamation: Current head dfe1688 differs from pull request most recent head 32332cc. Consider uploading reports for the commit 32332cc to get more accurate results
```diff
@@ Coverage Diff @@
## master #28390 +/- ##
==========================================
- Coverage 72.33% 72.31% -0.02%
==========================================
Files 683 683
Lines 100709 100619 -90
==========================================
- Hits 72848 72767 -81
+ Misses 26281 26277 -4
+ Partials 1580 1575 -5
```
| [Flag](https://app.codecov.io/gh/apache/beam/pull/28390/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [python](https://app.codecov.io/gh/apache/beam/pull/28390/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `82.82% <44.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Files Changed](https://app.codecov.io/gh/apache/beam/pull/28390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [sdks/go/container/tools/buffered\_logging.go](https://app.codecov.io/gh/apache/beam/pull/28390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9nby9jb250YWluZXIvdG9vbHMvYnVmZmVyZWRfbG9nZ2luZy5nbw==) | `67.85% <ø> (-1.20%)` | :arrow_down: |
| [...ython/apache\_beam/yaml/cache\_provider\_artifacts.py](https://app.codecov.io/gh/apache/beam/pull/28390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0veWFtbC9jYWNoZV9wcm92aWRlcl9hcnRpZmFjdHMucHk=) | `0.00% <0.00%> (ø)` | |
| [sdks/python/setup.py](https://app.codecov.io/gh/apache/beam/pull/28390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vc2V0dXAucHk=) | `0.00% <ø> (ø)` | |
| [sdks/python/apache\_beam/yaml/yaml\_provider.py](https://app.codecov.io/gh/apache/beam/pull/28390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0veWFtbC95YW1sX3Byb3ZpZGVyLnB5) | `70.08% <41.86%> (ø)` | |
| [.../python/apache\_beam/typehints/trivial\_inference.py](https://app.codecov.io/gh/apache/beam/pull/28390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHlwZWhpbnRzL3RyaXZpYWxfaW5mZXJlbmNlLnB5) | `85.54% <60.00%> (ø)` | |
| [sdks/python/apache\_beam/transforms/ptransform.py](https://app.codecov.io/gh/apache/beam/pull/28390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vdHJhbnNmb3Jtcy9wdHJhbnNmb3JtLnB5) | `92.73% <70.83%> (ø)` | |
| [.../python/apache\_beam/runners/worker/data\_sampler.py](https://app.codecov.io/gh/apache/beam/pull/28390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy93b3JrZXIvZGF0YV9zYW1wbGVyLnB5) | `98.02% <83.33%> (-0.17%)` | :arrow_down: |
| [...hon/apache\_beam/runners/dataflow/internal/names.py](https://app.codecov.io/gh/apache/beam/pull/28390?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-c2Rrcy9weXRob24vYXBhY2hlX2JlYW0vcnVubmVycy9kYXRhZmxvdy9pbnRlcm5hbC9uYW1lcy5weQ==) | `100.00% <100.00%> (ø)` | |
... and [11 files with indirect coverage changes](https://app.codecov.io/gh/apache/beam/pull/28390/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28390: Migrate "beam_PostCommit_Java_ValidatesRunner_*" Jenkins jobs to GitHub Actions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28390:
URL: https://github.com/apache/beam/pull/28390#issuecomment-1719803547
## Test Results
44 files - 102 44 suites - 102 1m 34s [:stopwatch:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "duration of all tests") - 37m 38s
362 tests - 972 362 [:heavy_check_mark:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "passed tests") - 939 0 [:zzz:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "skipped / disabled tests") - 33 0 [:x:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "failed tests") ±0
362 runs - 974 362 [:heavy_check_mark:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "passed tests") - 941 0 [:zzz:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "skipped / disabled tests") - 33 0 [:x:](https://github.com/EnricoMi/publish-unit-test-result-action/blob/v2.9.0/README.md#the-symbols "failed tests") ±0
Results for commit 99677afe. ± Comparison against base commit f86d9e2d.
<details>
<summary>This pull request <b>removes</b> 1336 and <b>adds</b> 362 tests. <i>Note that renamed tests count towards both.</i></summary>
```
id]
id`]
org.apache.beam.sdk.extensions.sql.BeamAnalyticFunctionsTest ‑ testDenseRankFunction
org.apache.beam.sdk.extensions.sql.BeamAnalyticFunctionsTest ‑ testFirstValueFunction
org.apache.beam.sdk.extensions.sql.BeamAnalyticFunctionsTest ‑ testLastValueFunction
org.apache.beam.sdk.extensions.sql.BeamAnalyticFunctionsTest ‑ testOverCumulativeSum
org.apache.beam.sdk.extensions.sql.BeamAnalyticFunctionsTest ‑ testOverCumulativeSumOrderByDesc
org.apache.beam.sdk.extensions.sql.BeamAnalyticFunctionsTest ‑ testOverRangeBoundedSum
org.apache.beam.sdk.extensions.sql.BeamAnalyticFunctionsTest ‑ testOverRowsBoundedSum
org.apache.beam.sdk.extensions.sql.BeamAnalyticFunctionsTest ‑ testPercentRankFunction
…
```
```
org.apache.beam.it.cassandra.CassandraResourceManagerTest ‑ testCleanupAllShouldNotDropStaticDatabase
org.apache.beam.it.cassandra.CassandraResourceManagerTest ‑ testCleanupAllShouldThrowErrorWhenCassandraClientFailsToClose
org.apache.beam.it.cassandra.CassandraResourceManagerTest ‑ testCleanupAllShouldThrowErrorWhenCassandraClientFailsToDropDatabase
org.apache.beam.it.cassandra.CassandraResourceManagerTest ‑ testCleanupShouldDropNonStaticDatabase
org.apache.beam.it.cassandra.CassandraResourceManagerTest ‑ testGetKeyspaceNameShouldReturnCorrectValue
org.apache.beam.it.cassandra.CassandraResourceManagerTest ‑ testGetUriShouldReturnCorrectValue
org.apache.beam.it.cassandra.CassandraResourceManagerTest ‑ testInsertDocumentsShouldThrowErrorWhenCassandraThrowsException
org.apache.beam.it.common.PipelineOperatorTest ‑ testFinishAfterCondition
org.apache.beam.it.common.PipelineOperatorTest ‑ testFinishAfterConditionJobStopped
org.apache.beam.it.common.PipelineOperatorTest ‑ testFinishAfterConditionTimeout
…
```
</details>
[test-results]:data:application/gzip;base64,H4sIAN05A2UC/13MyQ7CIBSF4VdpWLuwTFd8GcOYENtiGFaN7y7Ugdbl95/krMj5ySZ0HSg9DSgVn7tMiTL7sFSL5jrlNhKOv7qlovV/uvtHTedfcNJPh2BjDPFTYln6Z8Px8l364+bd4eb9nw7z7HMFEoIDSGdHwS5AgVkQTILhREklnVFWjQQoxuj5Aqsd+Y0GAQAA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn merged pull request #28390: Migrate "beam_PostCommit_Java_ValidatesRunner_*" Jenkins jobs to GitHub Actions
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn merged PR #28390:
URL: https://github.com/apache/beam/pull/28390
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] andreydevyatkin commented on a diff in pull request #28390: Migrate "beam_PostCommit_Java_ValidatesRunner_*" Jenkins jobs to GitHub Actions
Posted by "andreydevyatkin (via GitHub)" <gi...@apache.org>.
andreydevyatkin commented on code in PR #28390:
URL: https://github.com/apache/beam/pull/28390#discussion_r1326193868
##########
.github/workflows/beam_PostCommit_Java_ValidatesRunner_Direct_Java.yml:
##########
@@ -0,0 +1,109 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PostCommit Java ValidatesRunner Direct Java
+
+on:
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
+ workflow_dispatch:
+
+# This allows a subsequently queued workflow run to interrupt previous runs
+concurrency:
+ group: '${{ github.workflow }} @ ${{ github.event.issue.number || github.event.pull_request.head.label || github.sha || github.head_ref || github.ref }}-${{ github.event.schedule || github.event.comment.body || github.event.sender.login}}'
+ cancel-in-progress: true
+
+#Setting explicit permissions for the action to avoid the default permissions which are `write-all` in case of pull_request_target event
+permissions:
+ actions: write
+ pull-requests: write
+ checks: write
+ contents: read
+ deployments: read
+ id-token: none
+ issues: write
+ discussions: read
+ packages: read
+ pages: read
+ repository-projects: read
+ security-events: read
+ statuses: read
+
+env:
+ GRADLE_ENTERPRISE_ACCESS_KEY: ${{ secrets.GE_ACCESS_TOKEN }}
+ GRADLE_ENTERPRISE_CACHE_USERNAME: ${{ secrets.GE_CACHE_USERNAME }}
+ GRADLE_ENTERPRISE_CACHE_PASSWORD: ${{ secrets.GE_CACHE_PASSWORD }}
+
+jobs:
+ beam_PostCommit_Java_ValidatesRunner_Direct_Java:
+ name: ${{matrix.job_name}} (${{matrix.job_phrase}} ${{matrix.java_version}})
+ runs-on: [self-hosted, ubuntu-20.04, main]
+ timeout-minutes: 480
+ strategy:
+ fail-fast: false
+ matrix:
+ job_name: [beam_PostCommit_Java_ValidatesRunner_Direct_Java]
Review Comment:
Updated. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] github-actions[bot] commented on pull request #28390: Migrate "beam_PostCommit_Java_ValidatesRunner_*" Jenkins jobs to GitHub Actions
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #28390:
URL: https://github.com/apache/beam/pull/28390#issuecomment-1713617566
Assigning reviewers. If you would like to opt out of this review, comment `assign to next reviewer`:
R: @Abacn for label build.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] Abacn commented on a diff in pull request #28390: Migrate "beam_PostCommit_Java_ValidatesRunner_*" Jenkins jobs to GitHub Actions
Posted by "Abacn (via GitHub)" <gi...@apache.org>.
Abacn commented on code in PR #28390:
URL: https://github.com/apache/beam/pull/28390#discussion_r1326069260
##########
.github/workflows/beam_PostCommit_Java_ValidatesRunner_Dataflow_V2.yml:
##########
@@ -0,0 +1,94 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+name: PostCommit Java ValidatesRunner Dataflow V2
+
+on:
+ issue_comment:
+ types: [created]
+ schedule:
+ - cron: '0 */6 * * *'
Review Comment:
Dataflow V2 ValidatesRunner jobs (batch/stream) took very long to complete (5-7h) - on Jenkins the schedule was adjusted to every 8 hrs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org