You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Eric Sammer <es...@cloudera.com> on 2011/12/02 21:23:44 UTC
Review Request: FLUME-827: Avro client conn failure results in 60-second
wait before terminating
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2995/
-----------------------------------------------------------
Review request for Flume, Arvind Prabhakar and Prasad Mujumdar.
Summary
-------
Properly detect RPC failures and reconnect as necessary.
This addresses bug FLUME-827.
https://issues.apache.org/jira/browse/FLUME-827
Diffs
-----
i/flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java fead54f
i/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java e1f381d
Diff: https://reviews.apache.org/r/2995/diff
Testing
-------
New unit tests that confirm this works given a simple connect, send, kill server, send, start server, reconnect, deliver use case.
Ran manual tests with a pair of agents handling data during transient failures. Works!
Thanks,
Eric
Re: Review Request: FLUME-827: Avro client conn failure results in 60-second
wait before terminating
Posted by Arvind Prabhakar <ar...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2995/#review3604
-----------------------------------------------------------
Ship it!
+1
One thing I noted during the review which is unrelated is that the sink implementation is not thread safe. It is not a concern right now, but if we decide to move to multi-threaded pollable sink runners, that will need to be addressed.
- Arvind
On 2011-12-02 20:23:44, Eric Sammer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2995/
> -----------------------------------------------------------
>
> (Updated 2011-12-02 20:23:44)
>
>
> Review request for Flume, Arvind Prabhakar and Prasad Mujumdar.
>
>
> Summary
> -------
>
> Properly detect RPC failures and reconnect as necessary.
>
>
> This addresses bug FLUME-827.
> https://issues.apache.org/jira/browse/FLUME-827
>
>
> Diffs
> -----
>
> i/flume-ng-core/src/test/java/org/apache/flume/sink/TestAvroSink.java fead54f
> i/flume-ng-core/src/main/java/org/apache/flume/sink/AvroSink.java e1f381d
>
> Diff: https://reviews.apache.org/r/2995/diff
>
>
> Testing
> -------
>
> New unit tests that confirm this works given a simple connect, send, kill server, send, start server, reconnect, deliver use case.
> Ran manual tests with a pair of agents handling data during transient failures. Works!
>
>
> Thanks,
>
> Eric
>
>