You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2022/02/03 08:42:53 UTC
[GitHub] [apisix] kwanhur opened a new pull request #6245: build: purge all the dependent rocks
kwanhur opened a new pull request #6245:
URL: https://github.com/apache/apisix/pull/6245
### What this PR does / why we need it:
<!--- Why is this change required? What problem does it solve? -->
`make undeps` supports to uninstall dependent rocks.
use it in some cases:
- failed rocks after installed partial, clear then reinstall
- modify some rocks source codes, recover them, so purge and reinstall
<!--- If it fixes an open issue, please link to the issue here. -->
#6226
### Pre-submission checklist:
<!--
Please follow the PR manners:
1. Use Draft if the PR is not ready to be reviewed
2. Test is required for the feat/fix PR, unless you have a good reason
3. Doc is required for the feat PR
4. Use a new commit to resolve review instead of `push -f`
5. If you need to resolve merge conflicts after the PR is reviewed, please merge master but do not rebase
6. Use "request review" to notify the reviewer once you have resolved the review
7. Only reviewer can click "Resolve conversation" to mark the reviewer's review resolved
-->
* [x] Did you explain what problem does this PR solve? Or what new features have been added?
* [ ] Have you added corresponding test cases?
* [x] Have you modified the corresponding document?
* [ ] Is this PR backward compatible? **If it is not backward compatible, please discuss on the [mailing list](https://github.com/apache/apisix/tree/master#community) first**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] membphis commented on a change in pull request #6245: build: purge all the dependent rocks
Posted by GitBox <gi...@apache.org>.
membphis commented on a change in pull request #6245:
URL: https://github.com/apache/apisix/pull/6245#discussion_r798592483
##########
File path: Makefile
##########
@@ -161,6 +161,14 @@ deps: runtime
fi
+### undeps : Uninstallation dependencies
+.PHONY: undeps
+undeps:
+ @$(call func_echo_status, "$@ -> [ Start ]")
+ $(ENV_LUAROCKS) purge --tree=deps
Review comment:
Another easier way: `rm -rf deps`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] spacewander merged pull request #6245: build: purge all the dependent rocks
Posted by GitBox <gi...@apache.org>.
spacewander merged pull request #6245:
URL: https://github.com/apache/apisix/pull/6245
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] kwanhur commented on a change in pull request #6245: build: purge all the dependent rocks
Posted by GitBox <gi...@apache.org>.
kwanhur commented on a change in pull request #6245:
URL: https://github.com/apache/apisix/pull/6245#discussion_r799294888
##########
File path: Makefile
##########
@@ -161,6 +161,14 @@ deps: runtime
fi
+### undeps : Uninstallation dependencies
+.PHONY: undeps
+undeps:
+ @$(call func_echo_status, "$@ -> [ Start ]")
+ $(ENV_LUAROCKS) purge --tree=deps
Review comment:
this operation is easier, but deps install with `luarocks`, `luarocks purge` maybe more friendly when do the reversed.
`luarocks install` in `make deps`, `luarocks purge` in `make undeps`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org