[jira] [Commented] (HIVE-22526) Extract Compiler from Driver

["Hive QA (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-22526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16985455#comment-16985455 ] 

Hive QA commented on HIVE-22526:
--------------------------------



Here are the results of testing the latest attachment:
https://issues.apache.org/jira/secure/attachment/12987227/HIVE-22526.09.patch

{color:red}ERROR:{color} -1 due to no test(s) being added or modified.

{color:red}ERROR:{color} -1 due to 1 failed/errored test(s), 17754 tests executed
*Failed tests:*
{noformat}
org.apache.hadoop.hive.ql.TestMTQueries.testMTQueries1 (batchId=276)
{noformat}

Test results: https://builds.apache.org/job/PreCommit-HIVE-Build/19701/testReport
Console output: https://builds.apache.org/job/PreCommit-HIVE-Build/19701/console
Test logs: http://104.198.109.242/logs/PreCommit-HIVE-Build-19701/

Messages:
{noformat}
Executing org.apache.hive.ptest.execution.TestCheckPhase
Executing org.apache.hive.ptest.execution.PrepPhase
Executing org.apache.hive.ptest.execution.YetusPhase
Executing org.apache.hive.ptest.execution.ExecutionPhase
Executing org.apache.hive.ptest.execution.ReportingPhase
Tests exited with: TestsFailedException: 1 tests failed
{noformat}

This message is automatically generated.

ATTACHMENT ID: 12987227 - PreCommit-HIVE-Build

> Extract Compiler from Driver
> ----------------------------
>
>                 Key: HIVE-22526
>                 URL: https://issues.apache.org/jira/browse/HIVE-22526
>             Project: Hive
>          Issue Type: Sub-task
>          Components: Hive
>            Reporter: Miklos Gergely
>            Assignee: Miklos Gergely
>            Priority: Major
>             Fix For: 4.0.0
>
>         Attachments: HIVE-22526.01.patch, HIVE-22526.02.patch, HIVE-22526.03.patch, HIVE-22526.04.patch, HIVE-22526.05.patch, HIVE-22526.06.patch, HIVE-22526.07.patch, HIVE-22526.08.patch, HIVE-22526.09.patch
>
>
> The Driver class contains ~600 lines of code responsible for compiling the command. That means that from the command String a Plan needs to be created, and also a transaction needs to be started (in most of the cases). This is a thing done by the compile function, which has a lot of sub functions to help this task, while itself is also really big. All these codes should be put into a separate class, where it can do it's job without getting mixed with the other codes in the Driver.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)