[GitHub] [incubator-pegasus] empiredan commented on a diff in pull request #1133: feat(jemalloc): support to dump stats

[GitBox <gi...@apache.org>]

empiredan commented on code in PR #1133:
URL: https://github.com/apache/incubator-pegasus/pull/1133#discussion_r963399629


##########
.github/workflows/lint_and_test_cpp.yaml:
##########
@@ -373,6 +373,90 @@ jobs:
           ./scripts/config_hdfs.sh
           ./run.sh test --on_travis -m ${{ matrix.test_module }}
 
+  build_with_jemalloc:
+    name: Build with jemalloc
+    needs: cpp_clang_format_linter
+    runs-on: ubuntu-latest
+    container:
+      image: apache/pegasus:thirdparties-bin-test-jemallc-ubuntu1804-${{ github.base_ref }}
+    steps:
+      - uses: actions/checkout@v2
+      - name: Setup cache
+        uses: actions/cache@v3
+        with:
+          path: |
+            /github/home/.ccache
+          key: release_ccache

Review Comment:
   > Since the cache with the same name will overwrite the other, so it's better to use another name for jemalloc build type cache, such as `jemalloc_ccache`
   
   OK, I'll change the name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org