[PATCH] mod_cache_socache store_headers rc issues

[Jeff Trawick <tr...@gmail.com>]

gcc mentioned that rv was returned without being set, and after
looking a bit I noticed a few other glitches.

Any comments on the untested patch?

(I also see that the APLOGNO() invocations need to be fixed, but I
haven't looked further.)

-- 
Born in Roswell... married an alien...
http://emptyhammock.com/

Re: [PATCH] mod_cache_socache store_headers rc issues

[Graham Leggett <mi...@sharp.fm>]

On 27 Sep 2012, at 4:18 PM, Jeff Trawick <tr...@gmail.com> wrote:

> gcc mentioned that rv was returned without being set, and after
> looking a bit I noticed a few other glitches.
> 
> Any comments on the untested patch?

Any attempt at returning DECLINED is wrong at this point, as by the time we're calling store_headers() we're committed to this backend. I've updated all the lines where this was being returned in r1391396, thanks for catching this.

> (I also see that the APLOGNO() invocations need to be fixed, but I
> haven't looked further.)

Oops, that's fixed in r1391398.

Regards,
Graham
--