You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by "homatthew (via GitHub)" <gi...@apache.org> on 2023/02/22 21:16:57 UTC

[GitHub] [gobblin] homatthew commented on a diff in pull request #3648: [GOBBLIN-1779] Ability to filter datasets that contain non optional unions

homatthew commented on code in PR #3648:
URL: https://github.com/apache/gobblin/pull/3648#discussion_r1114966286


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/dataset/DatasetUtils.java:
##########
@@ -74,12 +74,19 @@ public Collection<CopyableFile> filter(FileSystem sourceFs, FileSystem targetFs,
    * @throws IOException
    */
   @SuppressWarnings("unchecked")
-  public static <T extends org.apache.gobblin.dataset.Dataset> DatasetsFinder<T> instantiateDatasetFinder(Properties props,
-      FileSystem fs, String default_class, Object... additionalArgs)
+  public static <T extends org.apache.gobblin.dataset.Dataset> DatasetsFinder<T> instantiateDatasetFinder(
+      Properties props, FileSystem fs, String default_class, Object... additionalArgs)
       throws IOException {
+    return instantiateDatasetFinder(DATASET_PROFILE_CLASS_KEY, props, fs, default_class, additionalArgs);
+  }
+
+  @SuppressWarnings("unchecked")
+  public static <T extends org.apache.gobblin.dataset.Dataset> DatasetsFinder<T> instantiateDatasetFinder(

Review Comment:
   New method used in `DatasetFinderFilteringDecorator` to instantiate dataset finder



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@gobblin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org