[jira] [Commented] (METRON-1064) Make init script OS-agnostic

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1064?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16100667#comment-16100667 ] 

ASF GitHub Bot commented on METRON-1064:
----------------------------------------

GitHub user merrimanr opened a pull request:

    https://github.com/apache/metron/pull/669

    METRON-1064: Make init script OS-agnostic

    ## Contributor Comments
    This PR makes the init scripts for metron-rest and metron-config OS-agnostic by:
    - moving the metron env file to "/etc/default" instead of "/etc/sysconfig"
    - using "su -c ..." to start the process instead of "runuser ..."
    - using the appropriate kill logic instead of "killproc"
    
    During testing I also uncovered a bug where the metron env file is not installed for the management UI if it and the REST application are installed on different hosts.  This PR fixes that bug as well. 
    
    I have tested this for regressions in full dev and am in the process of testing in an Ubuntu cluster.  I will update this thread once that testing is completely.  Until then, please don't merge this PR.
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). 
    - [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [x] Have you included steps or a guide to how the change may be verified and tested manually?
    - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && build_utils/verify_licenses.sh 
      ```
    
    - [x] Have you written or updated unit tests and or integration tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/merrimanr/incubator-metron ubuntu-init-scripts

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/669.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #669
    
----
commit 8954ad198f86236cddc2862ba0d305457ec19483
Author: merrimanr <me...@gmail.com>
Date:   2017-07-12T17:34:06Z

    changed location of env file

commit 7cd13e251b1a5fc0e87e89bcad10fb39ad4fbd5a
Author: Nick Allen <ni...@nickallen.org>
Date:   2017-07-12T18:29:32Z

    Altered init scripts to work on both Ubuntu and CentOS

commit 3fd5367aff42037c9f19fd5acf7eb137bbeb52b0
Author: merrimanr <me...@gmail.com>
Date:   2017-07-12T18:33:13Z

    Merge remote-tracking branch 'mirror/master' into ubuntu-init-scripts

commit 1551d5a65b7906ec1031e925aeb6cb5ff5ca8430
Author: merrimanr <me...@gmail.com>
Date:   2017-07-12T18:36:23Z

    Merge pull request #29 from nickwallen/BUG-81912
    
    Altered init scripts to work on both Ubuntu and CentOS

commit d591ce3bf5f1688858299047e86ab05994352acc
Author: merrimanr <me...@gmail.com>
Date:   2017-07-13T17:53:37Z

    changed kill command, added metron env file to management ui mpack script

----


> Make init script OS-agnostic
> ----------------------------
>
>                 Key: METRON-1064
>                 URL: https://issues.apache.org/jira/browse/METRON-1064
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Ryan Merriman
>
> Currently the init scripts for metron-rest and metron-config are specific to centos.  They should also work on ubuntu.  



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)