[GitHub] [trafficserver] shinrich commented on a change in pull request #7117: Fix #7116, skip the insertion of the same continuation to pending dns

[GitBox <gi...@apache.org>]

shinrich commented on a change in pull request #7117:
URL: https://github.com/apache/trafficserver/pull/7117#discussion_r471844107



##########
File path: iocore/hostdb/HostDB.cc
##########
@@ -1588,6 +1588,12 @@ HostDBContinuation::set_check_pending_dns()
   this->setThreadAffinity(this_ethread());
   HostDBContinuation *c = q.head;
   for (; c; c = static_cast<HostDBContinuation *>(c->link.next)) {
+    if (c == this) {
+      Warning("Skip the insertion of the same continuation to pending dns");
+      return false;

Review comment:
       One concern about this change is that if this continuation was the first request, returning false here will cause the caller to change the continuation handler.  There will be no continuation that will do the HostDBContinuation::dnsEvent.
   
   Maybe the probeEvent handler deals with it, but I'm not sure.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org