svn commit: r1865770 - in /pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger: PDFDebugger.java hexviewer/ASCIIPane.java hexviewer/HexEditor.java

[ti...@apache.org]

Author: tilman
Date: Fri Aug 23 16:03:27 2019
New Revision: 1865770

URL: http://svn.apache.org/viewvc?rev=1865770&view=rev
Log:
PDFBOX-4071: SonarQube fix: these UI classes won't be serialized

Modified:
    pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
    pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/ASCIIPane.java
    pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/HexEditor.java

Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java?rev=1865770&r1=1865769&r2=1865770&view=diff
==============================================================================
--- pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java (original)
+++ pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/PDFDebugger.java Fri Aug 23 16:03:27 2019
@@ -131,7 +131,7 @@ import org.apache.pdfbox.printing.PDFPag
  * @author Ben Litchfield
  * @author Khyrul Bashar
  */
-@SuppressWarnings({"serial","squid:MaximumInheritanceDepth"})
+@SuppressWarnings({"serial","squid:MaximumInheritanceDepth","squid:S1948"})
 public class PDFDebugger extends JFrame
 {
     private static final Set<COSName> SPECIALCOLORSPACES =
@@ -153,7 +153,6 @@ public class PDFDebugger extends JFrame
     private final JPanel documentPanel = new JPanel();
     private TreeStatusPane statusPane;
     private RecentFiles recentFiles;
-    @SuppressWarnings("squid:S1948")
     private WindowPrefs windowPrefs;
     private boolean isPageMode;
     private PDDocument document;

Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/ASCIIPane.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/ASCIIPane.java?rev=1865770&r1=1865769&r2=1865770&view=diff
==============================================================================
--- pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/ASCIIPane.java (original)
+++ pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/ASCIIPane.java Fri Aug 23 16:03:27 2019
@@ -30,6 +30,7 @@ import javax.swing.JComponent;
  * This class shows corresponding ASCII characters for bytes. For every 16 byte there is one line.
  * This paints the only visible contents at one time.
  */
+@SuppressWarnings({"serial","squid:S1948"})
 class ASCIIPane extends JComponent implements HexModelChangeListener
 {
     private final HexModel model;

Modified: pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/HexEditor.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/HexEditor.java?rev=1865770&r1=1865769&r2=1865770&view=diff
==============================================================================
--- pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/HexEditor.java (original)
+++ pdfbox/trunk/debugger/src/main/java/org/apache/pdfbox/debugger/hexviewer/HexEditor.java Fri Aug 23 16:03:27 2019
@@ -45,6 +45,7 @@ import javax.swing.border.LineBorder;
  *
  * This class hosts all the UI components of Hex view and coordinates among them.
  */
+@SuppressWarnings({"serial","squid:S1948"})
 class HexEditor extends JPanel implements SelectionChangeListener
 {
     private final HexModel model;