You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by "kaijchen (via GitHub)" <gi...@apache.org> on 2023/03/15 08:43:01 UTC
[GitHub] [incubator-uniffle] kaijchen opened a new pull request, #724: [MINOR] test: test class name should end with Test
kaijchen opened a new pull request, #724:
URL: https://github.com/apache/incubator-uniffle/pull/724
<!--
1. Title: [#<issue>] <type>(<scope>): <subject>
Examples:
- "[#123] feat(operator): support xxx"
- "[#233] fix: check null before access result in xxx"
- "[MINOR] refactor: fix typo in variable name"
- "[MINOR] docs: fix typo in README"
- "[#255] test: fix flaky test NameOfTheTest"
Reference: https://www.conventionalcommits.org/en/v1.0.0/
2. Contributor guidelines:
https://github.com/apache/incubator-uniffle/blob/master/CONTRIBUTING.md
3. If the PR is unfinished, please mark this PR as draft.
-->
### What changes were proposed in this pull request?
Rename some tests:
* SparkSQLWithDelegationShuffleManagerFallback.java => SparkSQLWithDelegationShuffleManagerFallbackTest.java
* SparkSQLWithDelegationShuffleManager.java => SparkSQLWithDelegationShuffleManagerTest.java
### Why are the changes needed?
test class name should end with Test
### Does this PR introduce _any_ user-facing change?
No.
### How was this patch tested?
CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] codecov-commenter commented on pull request #724: [MINOR] test: test class name should end with Test
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #724:
URL: https://github.com/apache/incubator-uniffle/pull/724#issuecomment-1469592441
## [Codecov](https://codecov.io/gh/apache/incubator-uniffle/pull/724?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#724](https://codecov.io/gh/apache/incubator-uniffle/pull/724?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (1edeeac) into [master](https://codecov.io/gh/apache/incubator-uniffle/commit/37d765998a6d5de31a0db4d4c1537b28790f21b4?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (37d7659) will **increase** coverage by `1.09%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## master #724 +/- ##
============================================
+ Coverage 60.63% 61.72% +1.09%
+ Complexity 1850 1754 -96
============================================
Files 229 205 -24
Lines 12749 10200 -2549
Branches 1064 1021 -43
============================================
- Hits 7730 6296 -1434
+ Misses 4609 3568 -1041
+ Partials 410 336 -74
```
[see 26 files with indirect coverage changes](https://codecov.io/gh/apache/incubator-uniffle/pull/724/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org
[GitHub] [incubator-uniffle] jerqi merged pull request #724: [MINOR] test: test class name should end with Test
Posted by "jerqi (via GitHub)" <gi...@apache.org>.
jerqi merged PR #724:
URL: https://github.com/apache/incubator-uniffle/pull/724
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org