You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildstream.apache.org by GitBox <gi...@apache.org> on 2022/09/23 21:33:53 UTC
[GitHub] [buildstream] dependabot[bot] opened a new pull request, #1763: build(deps): bump protobuf from 3.20.1 to 3.20.2 in /requirements
dependabot[bot] opened a new pull request, #1763:
URL: https://github.com/apache/buildstream/pull/1763
Bumps [protobuf](https://github.com/protocolbuffers/protobuf) from 3.20.1 to 3.20.2.
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a href="https://github.com/protocolbuffers/protobuf/releases">protobuf's releases</a>.</em></p>
<blockquote>
<h2>Protocol Buffers v3.20.2</h2>
<h1>C++</h1>
<ul>
<li>Reduce memory consumption of MessageSet parsing</li>
<li>This release addresses a <a href="https://github.com/protocolbuffers/protobuf/security/advisories/GHSA-8gq9-2x98-w8hf">Security Advisory for C++ and Python users</a></li>
</ul>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/protocolbuffers/protobuf/commit/a20c65f2cd549445fda907f7b83894c8eb7427d6"><code>a20c65f</code></a> Updating changelog</li>
<li><a href="https://github.com/protocolbuffers/protobuf/commit/c49fe79af9c295960477b7568f1765b202093143"><code>c49fe79</code></a> Updating version.json and repo version numbers to: 20.2</li>
<li><a href="https://github.com/protocolbuffers/protobuf/commit/806d7e4ce6f1fd0545cae226b94cb0249ea495c7"><code>806d7e4</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/10544">#10544</a> from deannagarcia/3.20.x</li>
<li><a href="https://github.com/protocolbuffers/protobuf/commit/ae718b39020ae6e6f8f5568e357d6893fd0fd29c"><code>ae718b3</code></a> Add missing includes</li>
<li><a href="https://github.com/protocolbuffers/protobuf/commit/b4c395aaedfacb32e2414d361fa85968c0991b34"><code>b4c395a</code></a> Apply patch</li>
<li><a href="https://github.com/protocolbuffers/protobuf/commit/6439c5c01349e74d4deb57c844a7ad4b7b13a302"><code>6439c5c</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/10531">#10531</a> from protocolbuffers/deannagarcia-patch-7</li>
<li><a href="https://github.com/protocolbuffers/protobuf/commit/22c79e6e4ca8be2bc2f700b2cdddca84d84659ce"><code>22c79e6</code></a> Update version.json</li>
<li><a href="https://github.com/protocolbuffers/protobuf/commit/c1a2d2ec29314975e725021ffe4334926dbaa56c"><code>c1a2d2e</code></a> Fix python release on macos (<a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/10512">#10512</a>)</li>
<li><a href="https://github.com/protocolbuffers/protobuf/commit/a826282e15efe3ae3a2aebb040fb1691b2233a1e"><code>a826282</code></a> Merge pull request <a href="https://github-redirect.dependabot.com/protocolbuffers/protobuf/issues/10505">#10505</a> from deannagarcia/3.20.x</li>
<li><a href="https://github.com/protocolbuffers/protobuf/commit/7639a710e10beb47bfc62f363680f7b04e8b3d26"><code>7639a71</code></a> Add version file</li>
<li>Additional commits viewable in <a href="https://github.com/protocolbuffers/protobuf/compare/v3.20.1...v3.20.2">compare view</a></li>
</ul>
</details>
<br />
[](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`.
[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)
---
<details>
<summary>Dependabot commands and options</summary>
<br />
You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
- `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
- `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language
- `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language
- `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language
- `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language
You can disable automated security fix PRs for this repo from the [Security Alerts page](https://github.com/apache/buildstream/network/alerts).
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on a diff in pull request #1763: build(deps): bump protobuf from 3.20.1 to 3.20.2 in /requirements
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #1763:
URL: https://github.com/apache/buildstream/pull/1763#discussion_r979214675
##########
requirements/requirements.txt:
##########
@@ -1,15 +1,13 @@
click==8.1.3
grpcio==1.46.0
-Jinja2==3.1.2
+jinja2==3.1.2
+markupsafe==2.1.1
pluginbase==1.0.1
-protobuf==3.20.1
+protobuf==3.20.2
psutil==5.9.0
-ruamel.yaml==0.17.21
-ruamel.yaml.clib==0.2.6
-setuptools==44.1.1
Review Comment:
This looks potentially dangerous
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] abderrahim commented on a diff in pull request #1763: build(deps): bump protobuf from 3.20.1 to 3.20.2 in /requirements
Posted by GitBox <gi...@apache.org>.
abderrahim commented on code in PR #1763:
URL: https://github.com/apache/buildstream/pull/1763#discussion_r979377889
##########
requirements/requirements.txt:
##########
@@ -1,15 +1,13 @@
click==8.1.3
grpcio==1.46.0
-Jinja2==3.1.2
+jinja2==3.1.2
+markupsafe==2.1.1
pluginbase==1.0.1
-protobuf==3.20.1
+protobuf==3.20.2
psutil==5.9.0
-ruamel.yaml==0.17.21
-ruamel.yaml.clib==0.2.6
-setuptools==44.1.1
Review Comment:
Indeed. We should disable this bot (I guess it's an apache bot) at least until we're using something standard. (I think it would be nice to switch to something like poetry instead of our hand crafted makefiles).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] abderrahim commented on a diff in pull request #1763: build(deps): bump protobuf from 3.20.1 to 3.20.2 in /requirements
Posted by GitBox <gi...@apache.org>.
abderrahim commented on code in PR #1763:
URL: https://github.com/apache/buildstream/pull/1763#discussion_r979378130
##########
requirements/requirements.txt:
##########
@@ -1,15 +1,13 @@
click==8.1.3
grpcio==1.46.0
-Jinja2==3.1.2
+jinja2==3.1.2
+markupsafe==2.1.1
pluginbase==1.0.1
-protobuf==3.20.1
+protobuf==3.20.2
psutil==5.9.0
-ruamel.yaml==0.17.21
-ruamel.yaml.clib==0.2.6
-setuptools==44.1.1
Review Comment:
Oh it's actually a github bot that apache have enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] cs-shadow commented on a diff in pull request #1763: build(deps): bump protobuf from 3.20.1 to 3.20.2 in /requirements
Posted by GitBox <gi...@apache.org>.
cs-shadow commented on code in PR #1763:
URL: https://github.com/apache/buildstream/pull/1763#discussion_r1059059565
##########
requirements/requirements.txt:
##########
@@ -1,15 +1,13 @@
click==8.1.3
grpcio==1.46.0
-Jinja2==3.1.2
+jinja2==3.1.2
+markupsafe==2.1.1
pluginbase==1.0.1
-protobuf==3.20.1
+protobuf==3.20.2
psutil==5.9.0
-ruamel.yaml==0.17.21
-ruamel.yaml.clib==0.2.6
-setuptools==44.1.1
Review Comment:
fwiw setuptools is NOT here because buildstream uses it at build-time. That should be in pyproject.toml as you mention above.
The reason setuptools is here (as a runtime requirement) is because buildtream uses `pkg_resources` around [here](https://github.com/apache/buildstream/blob/416bdd04a03d55e387d2d777cc115a295003daa2/src/buildstream/_pluginfactory/pluginoriginpip.py#L35) and `pkg_resources` module is provided by the `setuptools` package.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] dependabot[bot] closed pull request #1763: build(deps): bump protobuf from 3.20.1 to 3.20.2 in /requirements
Posted by GitBox <gi...@apache.org>.
dependabot[bot] closed pull request #1763: build(deps): bump protobuf from 3.20.1 to 3.20.2 in /requirements
URL: https://github.com/apache/buildstream/pull/1763
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] cs-shadow commented on a diff in pull request #1763: build(deps): bump protobuf from 3.20.1 to 3.20.2 in /requirements
Posted by GitBox <gi...@apache.org>.
cs-shadow commented on code in PR #1763:
URL: https://github.com/apache/buildstream/pull/1763#discussion_r1059110213
##########
requirements/requirements.txt:
##########
@@ -1,15 +1,13 @@
click==8.1.3
grpcio==1.46.0
-Jinja2==3.1.2
+jinja2==3.1.2
+markupsafe==2.1.1
pluginbase==1.0.1
-protobuf==3.20.1
+protobuf==3.20.2
psutil==5.9.0
-ruamel.yaml==0.17.21
-ruamel.yaml.clib==0.2.6
-setuptools==44.1.1
Review Comment:
we'd actually need `importlib.metadata` here that has is only in the standard library 3.8 onwards. There's a pypi package named `importlib_metadata` though which we can use. But i think swapping the setuptools dependency in favor of `importlib_metadata` won't be a bad idea, even if it'll lead to a try-except like:
```python
try:
import importlib.metadata as importlib_metadata
except ImportError:
import importlib_metadata
...
importlib_metadata.do_something()
```
##########
requirements/requirements.txt:
##########
@@ -1,15 +1,13 @@
click==8.1.3
grpcio==1.46.0
-Jinja2==3.1.2
+jinja2==3.1.2
+markupsafe==2.1.1
pluginbase==1.0.1
-protobuf==3.20.1
+protobuf==3.20.2
psutil==5.9.0
-ruamel.yaml==0.17.21
-ruamel.yaml.clib==0.2.6
-setuptools==44.1.1
Review Comment:
we'd actually need `importlib.metadata` here that is only in the standard library 3.8 onwards. There's a pypi package named `importlib_metadata` though which we can use. But i think swapping the setuptools dependency in favor of `importlib_metadata` won't be a bad idea, even if it'll lead to a try-except like:
```python
try:
import importlib.metadata as importlib_metadata
except ImportError:
import importlib_metadata
...
importlib_metadata.do_something()
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on a diff in pull request #1763: build(deps): bump protobuf from 3.20.1 to 3.20.2 in /requirements
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #1763:
URL: https://github.com/apache/buildstream/pull/1763#discussion_r982704054
##########
requirements/requirements.txt:
##########
@@ -1,15 +1,13 @@
click==8.1.3
grpcio==1.46.0
-Jinja2==3.1.2
+jinja2==3.1.2
+markupsafe==2.1.1
pluginbase==1.0.1
-protobuf==3.20.1
+protobuf==3.20.2
psutil==5.9.0
-ruamel.yaml==0.17.21
-ruamel.yaml.clib==0.2.6
-setuptools==44.1.1
Review Comment:
Actually maybe this doesn't belong here anyway. But instead https://github.com/apache/buildstream/blob/master/pyproject.toml#L4 should declare version range of setuptools this package needs to build. So when build isolation is used, pip will just fetch compatible setuptools and use it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] abderrahim commented on a diff in pull request #1763: build(deps): bump protobuf from 3.20.1 to 3.20.2 in /requirements
Posted by GitBox <gi...@apache.org>.
abderrahim commented on code in PR #1763:
URL: https://github.com/apache/buildstream/pull/1763#discussion_r1059080070
##########
requirements/requirements.txt:
##########
@@ -1,15 +1,13 @@
click==8.1.3
grpcio==1.46.0
-Jinja2==3.1.2
+jinja2==3.1.2
+markupsafe==2.1.1
pluginbase==1.0.1
-protobuf==3.20.1
+protobuf==3.20.2
psutil==5.9.0
-ruamel.yaml==0.17.21
-ruamel.yaml.clib==0.2.6
-setuptools==44.1.1
Review Comment:
Maybe we should consider using `importlib.resources` instead? It seems available since 3.7 which is the oldest version we support.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] nanonyme commented on a diff in pull request #1763: build(deps): bump protobuf from 3.20.1 to 3.20.2 in /requirements
Posted by GitBox <gi...@apache.org>.
nanonyme commented on code in PR #1763:
URL: https://github.com/apache/buildstream/pull/1763#discussion_r1059083795
##########
requirements/requirements.txt:
##########
@@ -1,15 +1,13 @@
click==8.1.3
grpcio==1.46.0
-Jinja2==3.1.2
+jinja2==3.1.2
+markupsafe==2.1.1
pluginbase==1.0.1
-protobuf==3.20.1
+protobuf==3.20.2
psutil==5.9.0
-ruamel.yaml==0.17.21
-ruamel.yaml.clib==0.2.6
-setuptools==44.1.1
Review Comment:
Yes, that should be used with fallback to importlib_resources on old Python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [buildstream] dependabot[bot] commented on pull request #1763: build(deps): bump protobuf from 3.20.1 to 3.20.2 in /requirements
Posted by GitBox <gi...@apache.org>.
dependabot[bot] commented on PR #1763:
URL: https://github.com/apache/buildstream/pull/1763#issuecomment-1367291116
Looks like protobuf is up-to-date now, so this is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@buildstream.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org