You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/08/09 08:09:06 UTC
[GitHub] [superset] zhaoyongjie opened a new pull request, #21025: fix: unable to show view as table modal
zhaoyongjie opened a new pull request, #21025:
URL: https://github.com/apache/superset/pull/21025
### SUMMARY
fix the "view as table" in the dashboard is unable to show when the second load.
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
#### Before
https://user-images.githubusercontent.com/2016594/183597857-150195d9-ec93-401c-97fa-9399d58c592c.mov
#### After
https://user-images.githubusercontent.com/2016594/183598309-f0748201-8011-4ff9-a07c-ac3cc8a3a786.mov
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #21025: fix: unable to show view as table modal
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #21025:
URL: https://github.com/apache/superset/pull/21025#issuecomment-1209155788
# [Codecov](https://codecov.io/gh/apache/superset/pull/21025?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#21025](https://codecov.io/gh/apache/superset/pull/21025?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (d1f1064) into [master](https://codecov.io/gh/apache/superset/commit/03764e6ae85380153b2c59e5e02149f9a157b13f?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (03764e6) will **decrease** coverage by `0.00%`.
> The diff coverage is `25.00%`.
```diff
@@ Coverage Diff @@
## master #21025 +/- ##
==========================================
- Coverage 66.35% 66.35% -0.01%
==========================================
Files 1767 1767
Lines 67348 67354 +6
Branches 7144 7146 +2
==========================================
Hits 44691 44691
- Misses 20829 20834 +5
- Partials 1828 1829 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `52.10% <25.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/21025?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...nents/DataTablesPane/components/useResultsPane.tsx](https://codecov.io/gh/apache/superset/pull/21025/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9jb21wb25lbnRzL3VzZVJlc3VsdHNQYW5lLnRzeA==) | `84.78% <25.00%> (-12.72%)` | :arrow_down: |
:mega: Codecov can now indicate which changes are the most critical in Pull Requests. [Learn more](https://about.codecov.io/product/feature/runtime-insights/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21025: fix: unable to show view as table modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21025:
URL: https://github.com/apache/superset/pull/21025#issuecomment-1209538777
@rusackas Ephemeral environment spinning up at http://52.11.118.90:8080. Credentials are `admin`/`admin`. Please allow several minutes for bootstrapping and startup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] github-actions[bot] commented on pull request #21025: fix: unable to show view as table modal
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #21025:
URL: https://github.com/apache/superset/pull/21025#issuecomment-1210111994
Ephemeral environment shutdown and build artifacts deleted.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on pull request #21025: fix: unable to show view as table modal
Posted by GitBox <gi...@apache.org>.
rusackas commented on PR #21025:
URL: https://github.com/apache/superset/pull/21025#issuecomment-1209506059
/testenv up
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] zhaoyongjie merged pull request #21025: fix: unable to show view as table modal
Posted by GitBox <gi...@apache.org>.
zhaoyongjie merged PR #21025:
URL: https://github.com/apache/superset/pull/21025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org