You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "luchunliang (via GitHub)" <gi...@apache.org> on 2025/06/17 11:58:56 UTC
[PR] [INLONG-11892][Sort] SortStandalone support Negative Acknowledgment mechanism for delivery failures [inlong]
luchunliang opened a new pull request, #11896:
URL: https://github.com/apache/inlong/pull/11896
Fixes #11892
### Motivation
<!--Explain here the context, and why you're making that change. What is the problem you're trying to solve.-->
### Modifications
<!--Describe the modifications you've done.-->
### Verifying this change
*(Please pick either of the following options)*
- [ ] This change is a trivial rework/code cleanup without any test coverage.
- [ ] This change is already covered by existing tests, such as:
*(please describe tests)*
- [ ] This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end deployment with large payloads (10MB)*
- *Extended integration test for recovery after broker failure*
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11892][Sort] SortStandalone support Negative Acknowledgment mechanism for delivery failures [inlong]
Posted by "aloyszhang (via GitHub)" <gi...@apache.org>.
aloyszhang commented on code in PR #11896:
URL: https://github.com/apache/inlong/pull/11896#discussion_r2153509694
##########
inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/fetcher/kafka/KafkaMultiTopicsFetcher.java:
##########
@@ -395,4 +395,16 @@ private void fetchFromKafka() throws Exception {
}
}
}
+
+ /**
+ * negativeAck Offset
+ *
+ * @param msgOffset String
+ */
+ @Override
+ public void negativeAck(String msgOffset) throws Exception {
Review Comment:
Kafka does support negativeAck
##########
inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/fetcher/kafka/KafkaSingleTopicFetcher.java:
##########
@@ -310,4 +310,16 @@ private void fetchFromKafka() throws Exception {
}
}
}
+
+ /**
+ * negativeAck Offset
+ *
+ * @param msgOffset String
+ */
+ @Override
+ public void negativeAck(String msgOffset) throws Exception {
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11892][Sort] SortStandalone support Negative Acknowledgment mechanism for delivery failures [inlong]
Posted by "luchunliang (via GitHub)" <gi...@apache.org>.
luchunliang commented on code in PR #11896:
URL: https://github.com/apache/inlong/pull/11896#discussion_r2153563601
##########
inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/fetcher/kafka/KafkaMultiTopicsFetcher.java:
##########
@@ -395,4 +395,16 @@ private void fetchFromKafka() throws Exception {
}
}
}
+
+ /**
+ * negativeAck Offset
+ *
+ * @param msgOffset String
+ */
+ @Override
+ public void negativeAck(String msgOffset) throws Exception {
Review Comment:
Kafka do not support negative ack.
Just pause topic consumer for 10 minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11892][Sort] SortStandalone support Negative Acknowledgment mechanism for delivery failures [inlong]
Posted by "luchunliang (via GitHub)" <gi...@apache.org>.
luchunliang commented on code in PR #11896:
URL: https://github.com/apache/inlong/pull/11896#discussion_r2153563751
##########
inlong-sdk/sort-sdk/src/main/java/org/apache/inlong/sdk/sort/fetcher/kafka/KafkaSingleTopicFetcher.java:
##########
@@ -310,4 +310,16 @@ private void fetchFromKafka() throws Exception {
}
}
}
+
+ /**
+ * negativeAck Offset
+ *
+ * @param msgOffset String
+ */
+ @Override
+ public void negativeAck(String msgOffset) throws Exception {
Review Comment:
Kafka do not support negative ack.
Just pause topic consumer for 10 minutes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-11892][Sort] SortStandalone support Negative Acknowledgment mechanism for delivery failures [inlong]
Posted by "luchunliang (via GitHub)" <gi...@apache.org>.
luchunliang merged PR #11896:
URL: https://github.com/apache/inlong/pull/11896
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org