You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by tbouron <gi...@git.apache.org> on 2016/04/07 14:16:05 UTC
[GitHub] brooklyn-ui pull request: Hotfix: Removing contains method from th...
GitHub user tbouron opened a pull request:
https://github.com/apache/brooklyn-ui/pull/25
Hotfix: Removing contains method from the Array prototype
This avoids breaking other parts of the UI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tbouron/brooklyn-ui hotfix/location-wizard
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-ui/pull/25.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #25
----
commit eee48e1b8e7b2b88164c2df15a8166b4c48fc2cd
Author: Thomas Bouron <th...@cloudsoftcorp.com>
Date: 2016-04-07T12:13:47Z
Hotfix: Removing contains method from the Array prototype to avoid breaking other parts of the UI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request: Hotfix: Removing contains method from th...
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206855774
> The code causing the problem is called only when loggerEnabled is true. Suggest disabling logging instead.
Even though, not removing the `contains` is really a big issue. I feel more confortable removing it as it affect every JS arrays.
Again, this is just a temporary fix, I'll look for another autocomplete library after 0.9.0
> Also can't believe they pollyfilled contains just to use it a single time on the line following it.
And yet, it is sadly true... But it's half of my mistake, I choose this library :(
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request: Hotfix: Skip the creation of the contain...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206895635
The fix works for me, merging.
Thanks @tbouron.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request: Hotfix: Removing contains method from th...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206848116
Was just about to reply to the email thread :).
The code causing the problem is called only when `loggerEnabled` is true. Suggest disabling logging instead.
Also can't believe they pollyfilled `contains` just to use it a single time on the line following it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request: Hotfix: Removing contains method from th...
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206866563
> My point is that with loggerEnabled=false the Array prototype will not be patched with contains, so no need to delete it.
My bad, I get what you are saying now. I'll update the PR
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request: Hotfix: Skip the creation of the contain...
Posted by tbouron <gi...@git.apache.org>.
Github user tbouron commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206872102
@neykov Done
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request: Hotfix: Removing contains method from th...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206857157
My point is that with `loggerEnabled=false` the `Array` prototype will not be patched with `contains`, so no need to delete it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request: Hotfix: Removing contains method from th...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the pull request:
https://github.com/apache/brooklyn-ui/pull/25#issuecomment-206858032
Also I am sure there are bugs in any library we use (as a general principle) :). The question is how long it takes before bumping into them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-ui pull request: Hotfix: Skip the creation of the contain...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-ui/pull/25
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---