[GitHub] [incubator-pinot] xiaohui-sun commented on a change in pull request #4149: [TE] support monitoring granularity for Holt Winters

[GitBox <gi...@apache.org>]

xiaohui-sun commented on a change in pull request #4149: [TE] support monitoring granularity for Holt Winters
URL: https://github.com/apache/incubator-pinot/pull/4149#discussion_r277107024
 
 

 ##########
 File path: thirdeye/thirdeye-pinot/src/main/java/org/apache/pinot/thirdeye/detection/components/HoltWintersDetector.java
 ##########
 @@ -112,13 +112,25 @@ public void init(HoltWintersDetectorSpec spec, InputDataFetcher dataFetcher) {
     this.pattern = spec.getPattern();
     this.smoothing = spec.getSmoothing();
     this.sensitivity = spec.getSensitivity();
+    this.monitoringGranularity = spec.getMonitoringGranularity();
+
+    if (this.monitoringGranularity.equals("1_MONTHS")) {
+      this.timeGranularity = MetricSlice.NATIVE_GRANULARITY;
 
 Review comment:
   What is the rationale behind this logic?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org