You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/07/30 13:33:36 UTC

[GitHub] [flink-docker] rmetzger opened a new pull request #35: [FLINK-16260] Add release.metadata files + Java 11 release for 1.11.1

rmetzger opened a new pull request #35:
URL: https://github.com/apache/flink-docker/pull/35


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-docker] rmetzger commented on a change in pull request #35: [FLINK-16260] Add release.metadata files + Java 11 release for 1.11.1

Posted by GitBox <gi...@apache.org>.
rmetzger commented on a change in pull request #35:
URL: https://github.com/apache/flink-docker/pull/35#discussion_r462999016



##########
File path: generate-stackbrew-library.sh
##########
@@ -47,7 +47,7 @@ pruneTags() {
     else
         # remove "latest" and any "scala_" tag, unless it is the latest version
         # the "scala_" tag has a similar semantic as the "latest" tag in docker registries. 
-        echo $tags | sed -E 's|, (scala\|latest)[-_[:alnum:]]*||g'
+        echo $tags | sed -E 's|, (scala\|latest)[-_.[:alnum:]]*||g'

Review comment:
       Otherwise, the tags look like this `Tags: 1.10.1-scala_2.11, 1.10-scala_2.11.11`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-docker] rmetzger closed pull request #35: [FLINK-16260] Add release.metadata files + Java 11 release for 1.11.1

Posted by GitBox <gi...@apache.org>.
rmetzger closed pull request #35:
URL: https://github.com/apache/flink-docker/pull/35


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-docker] rmetzger commented on pull request #35: [FLINK-16260] Add release.metadata files + Java 11 release for 1.11.1

Posted by GitBox <gi...@apache.org>.
rmetzger commented on pull request #35:
URL: https://github.com/apache/flink-docker/pull/35#issuecomment-666377662


   Thanks for the review ... merging.
   
   I'll then proceed with a PR towards the official docker repository.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org