[GitHub] [iceberg] stevenzwu commented on pull request #7366: Flink: add event time ordered assigner for FLIP-27 source

["stevenzwu (via GitHub)" <gi...@apache.org>]

stevenzwu commented on PR #7366:
URL: https://github.com/apache/iceberg/pull/7366#issuecomment-1516527197

   > As a user, one thing not mentioned in the Appendix that we still struggle with is understanding if we're assigning watermarks correctly. 
   > we aren't sure what the right `watermarkStrategy` is when using the aligner, and mathematically how `maxOutOfOrderness` affects it. If we could add a few sentences on this topic & a small code example, it would be really valuable for users.
   
   @dchristle yes, documentation and unit test would need to be added. right now, we are probably focus more on getting the code structure right
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org