You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/09/10 00:21:35 UTC

[GitHub] [beam] robertwb commented on a change in pull request #15223: [BEAM-12662] Get Flink version from cluster.

robertwb commented on a change in pull request #15223:
URL: https://github.com/apache/beam/pull/15223#discussion_r705807239



##########
File path: sdks/python/apache_beam/runners/portability/flink_uber_jar_job_server.py
##########
@@ -68,7 +68,7 @@ def executable_jar(self):
               'the scheme is specified. If using a local file path, make sure '
               'the file exists; you may have to first build the job server '
               'using `./gradlew runners:flink:%s:job-server:shadowJar`.' %
-              (self._executable_jar, self._flink_version))
+              (self._executable_jar, self.flink_version())

Review comment:
       SGTM




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org