You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/25 10:12:52 UTC

[GitHub] [flink] 1996fanrui opened a new pull request, #21398: [FLINK-30214][mini_cluster] MiniCluster adapt the jobvertex-parallelism-overrides

1996fanrui opened a new pull request, #21398:
URL: https://github.com/apache/flink/pull/21398

   ## What is the purpose of the change
   
   When turn up the parallelism, the resources isn't enough for MiniCluster.
   
   ## Brief change log
   
   MiniCluster adapt the jobvertex-parallelism-overrides
   
   
   ## Verifying this change
   
   This change added tests and can be verified as follows:
   
   I will add some tests later.
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): no
     - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: no
     - The serializers: no
     - The runtime per-record code paths (performance sensitive): no
     - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: no
     - The S3 file system connector: no
   
   ## Documentation
   
     - Does this pull request introduce a new feature? no
     - If yes, how is the feature documented? not documented
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] flinkbot commented on pull request #21398: [FLINK-30214][mini_cluster] MiniCluster adapt the jobvertex-parallelism-overrides

Posted by GitBox <gi...@apache.org>.
flinkbot commented on PR #21398:
URL: https://github.com/apache/flink/pull/21398#issuecomment-1327289959

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "e79c88a8cdbe4d96262754591ed20833b2c0e4b7",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "e79c88a8cdbe4d96262754591ed20833b2c0e4b7",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * e79c88a8cdbe4d96262754591ed20833b2c0e4b7 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     The @flinkbot bot supports the following commands:
   
    - `@flinkbot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #21398: [FLINK-30214][mini_cluster] MiniCluster adapt the jobvertex-parallelism-overrides

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #21398:
URL: https://github.com/apache/flink/pull/21398#issuecomment-1328573385

   Hi @gyfora @mxm 
   
   As we know, when the flink job run on IDEA, it will use the MiniCluster. And `PerJobMiniClusterFactory#getMiniClusterConfig` generate the `numSlotsPerTaskManager` by the JobGraph. However, the `numSlotsPerTaskManager` may be wrong after using `jobvertex-parallelism-overrides`. So the `numSlotsPerTaskManager` should be generated according to the JobGraph and `jobvertex-parallelism-overrides`.
   
   Please help take a look this PR in your free time, thanks~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #21398: [FLINK-30214][mini_cluster] MiniCluster adapt the jobvertex-parallelism-overrides

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #21398:
URL: https://github.com/apache/flink/pull/21398#issuecomment-1330953813

   @gyfora @mxm , thanks a lot for your review~


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] 1996fanrui commented on pull request #21398: [FLINK-30214][mini_cluster] MiniCluster adapt the jobvertex-parallelism-overrides

Posted by GitBox <gi...@apache.org>.
1996fanrui commented on PR #21398:
URL: https://github.com/apache/flink/pull/21398#issuecomment-1327654213

   @flinkbot run azure


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink] gyfora merged pull request #21398: [FLINK-30214][mini_cluster] MiniCluster adapt the jobvertex-parallelism-overrides

Posted by GitBox <gi...@apache.org>.
gyfora merged PR #21398:
URL: https://github.com/apache/flink/pull/21398


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org