[jira] Commented: (TAPESTRY-1663) @RadioGroup client-side validation does not work

["Robert Binna (JIRA)" <de...@tapestry.apache.org>]

    [ https://issues.apache.org/jira/browse/TAPESTRY-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12542416 ] 

Robert Binna commented on TAPESTRY-1663:
----------------------------------------

The fix introduced by Jesse Kuhnert on 28/Jul/07 on file src/js/dojo-0.4.3/src/validate/check.js unfortunately breaks validation for comboboxes (e.g. validators="validators:required" in PropertySelection).

In the case of (_b.type=="select-one") && (_b.selectedIndex!=-1) the else-branch is entered and dojo.lang.isArrayLike(_b) is true; but _b does not have any member with a property .checked, because it is a select-box and its elements are options containing the property .selected;

Suggested fix:
Replace 
if(!dj_undef("type",_b)&&(_b.type=="select-one"||_b.type=="select-multiple")&&(_b.selectedIndex==-1||/^\s*$/.test(_b.options[_b.selectedIndex].value))){
_3[_3.length]=_b.name;
}else{
if(dojo.lang.isArrayLike(_b)){
...
}

by
if(!dj_undef("type",_b)&&(_b.type=="select-one"||_b.type=="select-multiple")) {
  if(_b.selectedIndex==-1||/^\s*$/.test(_b.options[_b.selectedIndex].value))){
    _3[_3.length]=_b.name;
  }
}else{
if(dojo.lang.isArrayLike(_b)){
var _d=false;
for(var j=0;j<_b.length;j++){
if(_b[j].checked){
_d=true;
}

In that way, validation for select-one and select-multiple will be ok, if there is a selectedIndex, and the else-branch (which is only meant for the radio buttons...) is never entered.



> @RadioGroup client-side validation does not work
> ------------------------------------------------
>
>                 Key: TAPESTRY-1663
>                 URL: https://issues.apache.org/jira/browse/TAPESTRY-1663
>             Project: Tapestry
>          Issue Type: Bug
>          Components: JavaScript
>    Affects Versions: 4.1.2
>         Environment: Firefox 2.0.0.5 and InternetExplorer 7.0.5730
>            Reporter: Cyrille
>            Assignee: Marcus Schulte
>             Fix For: 4.1.3, 4.1.4
>
>
> The @RadioGroup client-side validation does not work: nothing append at form submit. Notive that it works fine on server-side.
> The Template part :
> <div jwcid="radioGroup01@RadioGroup" selected="ognl:radioGroup01Selected" displayName="RadioGroup 01" validators="validators:required" >
>  choix 1<input type="text" jwcid="radio01@Radio" value="literal:R01" /> <br/>
>  choix 2<input type="radio" jwcid="radio02@Radio" value="literal:R02" />
> </div>
> The generated html :
> ...
> <div>
>  choix 1<input type="radio" name="radioGroup01" id="radioGroup010" value="0" /><br/> 
> choix 2<input type="radio" name="radioGroup01" id="radioGroup011" value="1" />
> </div>
> ...
> <script type="text/javascript"><!--
> dojo.addOnLoad(function(e) {
> dojo.require("tapestry.form");tapestry.form.registerForm("theForm");
> tapestry.form.focusField('text01');
> tapestry.form.clearProfiles('theForm'); tapestry.form.registerProfile('theForm',{"required":["text01","radioGroup01"],"text01":{"required":["Vous devez entrer une valeur pour Le Text 01."]},"radioGroup01":{"required":["Vous devez entrer une valeur pour RadioGroup 01."]}});});
> // --></script></body>
> </html>
> I had a try with a "required" @TextField on the same page, and the client-side works fine for the field, there is only the RadioGroup client-side validation which does not works.
> I think about that, but I a beginner, so it's juste a idea : the javascript validation probably works only with element id, but in case of radios in a radiogroup only the name attribute is the same for all radios.
> Ask me for more detail if needed.
> Cheers
> Cyrille

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tapestry.apache.org
For additional commands, e-mail: dev-help@tapestry.apache.org