You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by corneadoug <gi...@git.apache.org> on 2016/07/05 06:18:30 UTC
[GitHub] zeppelin pull request #1130: [ZEPPELIN-1113] Don't save Paragraph ColWidth i...
GitHub user corneadoug opened a pull request:
https://github.com/apache/zeppelin/pull/1130
[ZEPPELIN-1113] Don't save Paragraph ColWidth if not necessary
### What is this PR for?
We currently are saving the ColWidth changes all the time, while it is not necessary if the value is the same.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1113
### How should this be tested?
* Select a Col-12 Paragraph and use the shortcut Ctr+Shift+ = to make it bigger
* You shouldn't see any `Send >> "COMMIT_PARAGRAPH"` in your browser console
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/dontSendSimilarColWidth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1130
----
commit 7d471c00dfed5af2b41a5481611788269f3998b0
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-05T06:11:44Z
Add parameter to changeColWidth and check value
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1130: [ZEPPELIN-1113] Don't save Paragraph ColWidth if not n...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1130
Re-Trigger CI, Tests are good locally
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1130: [ZEPPELIN-1113] Don't save Paragraph ColWidth if not n...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the issue:
https://github.com/apache/zeppelin/pull/1130
CI is green at last :) Merging if there is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1130: [ZEPPELIN-1113] Don't save Paragraph ColWidth i...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1130: [ZEPPELIN-1113] Don't save Paragraph ColWidth i...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug closed the pull request at:
https://github.com/apache/zeppelin/pull/1130
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1130: [ZEPPELIN-1113] Don't save Paragraph ColWidth i...
Posted by corneadoug <gi...@git.apache.org>.
GitHub user corneadoug reopened a pull request:
https://github.com/apache/zeppelin/pull/1130
[ZEPPELIN-1113] Don't save Paragraph ColWidth if not necessary
### What is this PR for?
We currently are saving the ColWidth changes all the time, while it is not necessary if the value is the same.
### What type of PR is it?
Improvement
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1113
### How should this be tested?
* Select a Col-12 Paragraph and use the shortcut Ctr+Shift+ = to make it bigger
* You shouldn't see any `Send >> "COMMIT_PARAGRAPH"` in your browser console
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/corneadoug/incubator-zeppelin fix/dontSendSimilarColWidth
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1130.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1130
----
commit 7d471c00dfed5af2b41a5481611788269f3998b0
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-05T06:11:44Z
Add parameter to changeColWidth and check value
commit ddbb04af1942e097078b5f9f9e7663165a2ce70a
Author: Damien CORNEAU <co...@gmail.com>
Date: 2016-07-05T08:52:43Z
Fix setting change width
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1130: [ZEPPELIN-1113] Don't save Paragraph ColWidth if not n...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1130
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---