You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@climate.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/21 17:06:00 UTC
[jira] [Commented] (CLIMATE-353) Bounds doesn't cast input values
into proper format
[ https://issues.apache.org/jira/browse/CLIMATE-353?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16333597#comment-16333597 ]
ASF GitHub Bot commented on CLIMATE-353:
----------------------------------------
GitHub user MichaelArthurAnderson opened a pull request:
https://github.com/apache/climate/pull/495
CLIMATE-353 Bounds doesnt cast input values into proper format
CLIMATE-353 Bounds doesnt cast input values into proper format
- Extracted validation functions for end, start, and min / max lat / lon.
- Validate end and start are always of type datetime. min / max lat / lon were already being cast to float.
- Pylinting.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/MichaelArthurAnderson/climate CLIMATE-353
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/climate/pull/495.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #495
----
commit f7346ad34c5ca6f028eb78d731ccf584927bc912
Author: michaelarthuranderson <mi...@...>
Date: 2018-01-21T17:01:32Z
CLIMATE-353 Bounds doesnt cast input values into proper format
----
> Bounds doesn't cast input values into proper format
> ---------------------------------------------------
>
> Key: CLIMATE-353
> URL: https://issues.apache.org/jira/browse/CLIMATE-353
> Project: Apache Open Climate Workbench
> Issue Type: Bug
> Components: general
> Affects Versions: 0.3-incubating
> Reporter: Michael Joyce
> Assignee: Michael Anderson
> Priority: Major
> Fix For: 1.3.0
>
>
> Similar to CLIMATE-352, The Bounds object should attempt to ensure that input data is in the expected format, otherwise there can be problems when comparing values. This includes the setters as well!
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)