[GitHub] [beam] Malarg commented on a diff in pull request #25397: Issue25329 fix cors issue when no internet

["Malarg (via GitHub)" <gi...@apache.org>]

Malarg commented on code in PR #25397:
URL: https://github.com/apache/beam/pull/25397#discussion_r1105520623


##########
playground/frontend/playground_components/lib/src/controllers/playground_controller.dart:
##########
@@ -49,6 +49,7 @@ const kTitle = 'Catalog';
 const kExecutionCancelledText = '\nPipeline cancelled';
 const kPipelineOptionsParseError =
     'Failed to parse pipeline options, please check the format (example: --key1 value1 --key2 value2), only alphanumeric and ",*,/,-,:,;,\',. symbols are allowed';
+const kInternetConnectionUnavailable = 'Internet connection unavailable';
 const kCachedResultsLog =
     'The results of this example are taken from the Apache Beam Playground cache.\n';

Review Comment:
   done



##########
playground/frontend/playground_components/lib/src/repositories/code_client/grpc_code_client.dart:
##########
@@ -18,10 +18,9 @@
 
 import 'package:grpc/grpc.dart';
 
+import '../../../playground_components.dart';

Review Comment:
   done



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org