You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "nchammas (via GitHub)" <gi...@apache.org> on 2023/12/18 03:41:03 UTC
[PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
nchammas opened a new pull request, #44393:
URL: https://github.com/apache/spark/pull/44393
### What changes were proposed in this pull request?
- Remove a bunch of Liquid directives that are not necessary.
- Add a table of contents to the built-in SQL functions page.
- Move the generated HTML for built-in SQL functions to a subdirectory.
### Why are the changes needed?
To reduce confusion for maintainers.
### Does this PR introduce _any_ user-facing change?
Yes. It add a table of contents. Otherwise, the generated docs are identical.
### How was this patch tested?
I built Spark, ran `./sql/create-docs.sh`, and reviewed the generated docs in my browser.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1433287722
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,105 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-agg-funcs-table.html' %}
+* Table of contents
+{:toc}
Review Comment:
I'll try the bold and see how that looks. I'll update the screenshot in the PR description, too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1433284403
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,105 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-agg-funcs-table.html' %}
+* Table of contents
+{:toc}
Review Comment:
I thought the same thing, but unfortunately the TOC depth can only be set site-wide: https://github.com/toshimaru/jekyll-toc/issues/120
Shall I remove the TOC entirely?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1444173343
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,125 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
Review Comment:
No worries. I will reopen the PR.
I will also tweak things, if possible, so that `SKIP_API=1` will work even if the SQL API docs have never been generated before, _without_ requiring all of the conditional includes, because they really clutter things up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1433293035
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,105 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-agg-funcs-table.html' %}
+* Table of contents
+{:toc}
Review Comment:
Done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #44393:
URL: https://github.com/apache/spark/pull/44393#issuecomment-1862025180
@huaxingao, you may also be interested in reviewing this since you reviewed #28224.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1433286110
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,105 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-agg-funcs-table.html' %}
+* Table of contents
+{:toc}
Review Comment:
Hmmmmmmm.... I wonder if it's better to just remove it for now ....
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1444169163
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,125 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
Review Comment:
Let me revert this for now (as it technically breaks the documentation build)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon closed pull request #44393: [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation
URL: https://github.com/apache/spark/pull/44393
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1444171705
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,125 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
Review Comment:
I think we can just revive the `if`s there, and I think we can just go ahead and merge. Let me reopen this PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1445378532
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,125 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
Review Comment:
> I think we can just revive the `if`s there, and I think we can just go ahead and merge. Let me reopen this PR.
@HyukjinKwon - Actually, thinking about this a bit more , is this really the behavior we want to have?
It's technically a type of silent failure if Jekyll successfully builds our docs but can't find some file that was referenced via `include` or `include_relative`. The way `docs/sql-ref-functions-builtin.md` is currently setup makes it so that Jekyll will never detect these missing includes.
Isn't that actually a bad thing? Using this pattern, how will developers know that the documentation built correctly without manually reviewing _every_ rendered site where they wrote a conditional include?
It seems like we need a way to ignore missing includes only when `SKIP_API=1`. Do you agree?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1444171782
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,125 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
Review Comment:
Oops, the branch was removed so I can't reopen the PR 😢
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1433286359
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,105 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-agg-funcs-table.html' %}
+* Table of contents
+{:toc}
Review Comment:
not sure which one would be better :-).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1445096577
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,125 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
Review Comment:
I've opened #44627 to address the build issue so we are not caught off guard like this again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1444171559
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,125 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
Review Comment:
I think the reason is that the canonical `bundle exec jekyll build` would pass because it will trigger the full build of API. If `SKIP_API=1` is specified, it will skip the API build (which will skip SQL API generation, then the HTML files would not exist).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on PR #44393:
URL: https://github.com/apache/spark/pull/44393#issuecomment-1859504983
cc @maropu for review, since you authored #28224.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on PR #44393:
URL: https://github.com/apache/spark/pull/44393#issuecomment-1867097785
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "huaxingao (via GitHub)" <gi...@apache.org>.
huaxingao commented on PR #44393:
URL: https://github.com/apache/spark/pull/44393#issuecomment-1864914232
cc @HyukjinKwon
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1433281260
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,105 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-agg-funcs-table.html' %}
+* Table of contents
+{:toc}
Review Comment:
Can we probably have the toc only for the head titles? I think `Examples` subtitle is too verbose.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1433286296
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,105 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
- {% if static_file.name == 'generated-agg-funcs-table.html' %}
+* Table of contents
+{:toc}
Review Comment:
Or .. we can switch `Examples` to just bold instead of h3 title ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1445498525
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,125 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
Review Comment:
Yeah .. as long as those options work (e.g., `SKIP_API=1.`), it should be fine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "HyukjinKwon (via GitHub)" <gi...@apache.org>.
HyukjinKwon commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1444169083
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,125 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
Review Comment:
Actually it was my bad. we still need this if-else because of `SKIP_API=1 bundle exec jekyll build`. It fails as below
```
Configuration file: /.../workspace/forked/spark/docs/_config.yml
Source: /.../workspace/forked/spark/docs
Destination: /.../workspace/forked/spark/docs/_site
Incremental build: disabled. Enable with --incremental
Generating...
Liquid Exception: Could not locate the included file '_generated_function_html/agg-funcs-table.html' in any of ["/.../workspace/forked/spark/docs/"]. Ensure it exists in one of those directories and, if it is a symlink, does not point outside your site source. in sql-ref-functions-builtin.md
...
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-46437][DOCS] Remove cruft from the built-in SQL functions documentation [spark]
Posted by "nchammas (via GitHub)" <gi...@apache.org>.
nchammas commented on code in PR #44393:
URL: https://github.com/apache/spark/pull/44393#discussion_r1444171117
##########
docs/sql-ref-functions-builtin.md:
##########
@@ -17,202 +17,125 @@ license: |
limitations under the License.
---
-{% for static_file in site.static_files %}
Review Comment:
Hmm, that's strange. Does the PR build not build documentation? Because the build was passing as of a9ae743eb66004dce9a9dd7e7ca24ef17823d5aa (the latest commit in the PR), and the merge into master at e4b5977c9b7b808d32a6370dccc33eaeb235085e also had a passing build.
Here's the documentation build after the merge: https://github.com/apache/spark/actions/runs/7294850973/job/19880408450
What am I missing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org