You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/08/19 07:07:14 UTC
[GitHub] [airflow] potiuk commented on a change in pull request #10390: When precommits are run, output is silenced
potiuk commented on a change in pull request #10390:
URL: https://github.com/apache/airflow/pull/10390#discussion_r472785575
##########
File path: scripts/ci/libraries/_build_images.sh
##########
@@ -559,12 +558,27 @@ function build_ci_image() {
echo >&2
exit 1
fi
+ if [[ -n ${SPIN_PID:=""} ]]; then
+ kill -HUP "${SPIN_PID}" || true
+ wait "${SPIN_PID}" || true
+ echo > "${DETECTED_TERMINAL}"
Review comment:
it can be /dev/tty if we cannot detect therminal with $(tty) (which happens inside pre-commit on git commit (it is always non-interactive by design)
##########
File path: scripts/ci/libraries/_build_images.sh
##########
@@ -559,12 +558,27 @@ function build_ci_image() {
echo >&2
exit 1
fi
+ if [[ -n ${SPIN_PID:=""} ]]; then
+ kill -HUP "${SPIN_PID}" || true
+ wait "${SPIN_PID}" || true
+ echo > "${DETECTED_TERMINAL}"
Review comment:
it can be /dev/tty if we cannot detect therminal with $(tty) (which happens inside pre-commit on git commit (it is always non-interactive by design)
```
elif [[ ${DETECTED_TERMINAL:=$(tty)} != "not a tty" ]]; then
````
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org