[jira] [Commented] (CASSANDRA-13976) introduce max_hint_window_in_min, deprecate max_hint_window_in_ms

["Kurt Greaves (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-13976?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273722#comment-16273722 ] 

Kurt Greaves commented on CASSANDRA-13976:
------------------------------------------

Not necessary to support both, just convert the minute value to ms if the {{max_hint_window_in_min}} property exists, otherwise use the {{max_hint_window_in_ms}} value or default if neither exist.

TBH I don't think we should ever completely get rid of the ms config option as I wouldn't be surprised if there are tests relying on setting it to <1min, but we could remove it from the default yaml and add in the minute based config instead.

> introduce max_hint_window_in_min, deprecate max_hint_window_in_ms
> -----------------------------------------------------------------
>
>                 Key: CASSANDRA-13976
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-13976
>             Project: Cassandra
>          Issue Type: Improvement
>            Reporter: Jon Haddad
>            Assignee: Kirk True
>            Priority: Minor
>              Labels: lhf
>             Fix For: 4.0
>
>
> Milliseconds is unnecessarily precise.  At most, minutes would be used.  Config in 4.0 should default to a minute granularity, but if the max_hint_window_in_min isn't set should fall back on max_hint_window_in_ms and emit a warning.
> max_hint_window_in_min: 180 # new default, still at 3 hours.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org