You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by Tibor Digana <ti...@apache.org> on 2019/03/23 21:47:04 UTC
looking for some volunteer
It's going to be very pedant work for someone who want to help us in
Surefire.
I am looking for some volunteer who will remove the deprecated config param
`forkMode` in favor of `forkCount`. All our ITs should use `forkCount`
since then.
Additionally, the volunteer should deprecate `surefire-junit4` provider.
Instead `surefire-junit47` provider should be selected as default provider
for JUnit4 tests. Again the ITs should be changed and plugin dependencies
should use `surefire-junit4` provider in place where it was not specified.
It's easy to do. When you see the usages of `.forkMode()` method - only 20
in `surefire-its` and 43 usages of `<forkMode>` in
`surefire-its/src/test/resources`.
Successful build must prove that the changes have been applied correctly.
The changes should be in a pull request on GitHub.
Cheers
Tibor
Re: looking for some volunteer
Posted by Enrico Olivelli <eo...@gmail.com>.
Il lun 25 mar 2019, 00:19 Tibor Digana <ti...@apache.org> ha scritto:
> Hi Dejan,
>
> Good to hear. In our Jira are two issues related to my original email:
> https://issues.apache.org/jira/browse/SUREFIRE-1654
> https://issues.apache.org/jira/browse/SUREFIRE-1494
> If you have any questions, feel free to ask here.
> Pls run the build locally (mvn -P run-its install) until our TravisCI
> build would be ready for you. The build takes cca 1 hour to complete.
> We should solve these two issue in two separate pull requests.
> I guess these tasks require very good preparation and analysis of ITs
> before making any changes.
>
> @Enrico can you pls investigate TravisCI, why it still behaves so much
> differently from Jenkins CI and fails?
> Is it really due to the deployed SNAPSHOT versions at ASF Nexus?
>
Sure
Cheers
Enrico
>
> Thx
>
> Cheers
> Tibor
>
>
> On Sun, Mar 24, 2019 at 3:23 PM Dejan Stojadinovic <de...@gmail.com>
> wrote:
>
>> Hi Tibor,
>>
>> I volunteer for this. I have a solid experience with maven usage and also
>> contributed few (easy) maven commits:
>> https://github.com/apache/maven/commits?author=dejan2609
>>
>> Regards,
>> Dejan Stojadinović
>>
>> On 2019/03/23 21:47:04, Tibor Digana <ti...@apache.org> wrote:
>> > It's going to be very pedant work for someone who want to help us in
>> > Surefire.
>> >
>> > I am looking for some volunteer who will remove the deprecated config
>> param
>> > `forkMode` in favor of `forkCount`. All our ITs should use `forkCount`
>> > since then.
>> >
>> > Additionally, the volunteer should deprecate `surefire-junit4` provider.
>> > Instead `surefire-junit47` provider should be selected as default
>> provider
>> > for JUnit4 tests. Again the ITs should be changed and plugin
>> dependencies
>> > should use `surefire-junit4` provider in place where it was not
>> specified.
>> >
>> > It's easy to do. When you see the usages of `.forkMode()` method - only
>> 20
>> > in `surefire-its` and 43 usages of `<forkMode>` in
>> > `surefire-its/src/test/resources`.
>> >
>> > Successful build must prove that the changes have been applied
>> correctly.
>> > The changes should be in a pull request on GitHub.
>> >
>> > Cheers
>> > Tibor
>> >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>> For additional commands, e-mail: dev-help@maven.apache.org
>>
>>
Re: Surefire CNFE
Posted by Tibor Digana <ti...@apache.org>.
Thx Romain.
My gmail really did not show me the begin of this thread.
Now in the mail-archive.apache.org i see that it was related to Dejan's
work.
The work is still in progress and we have some issues with CNFE which is
still okay.
For all, currently "surefire-junit4" is activated by default if
e.g.junit:junit:4.12 appears in test dependencies.
Here in Dejan's change, we attempt to make "surefire-junit47" activated as
default Provider for libraries JUnit 4.7+.
It is a little upgrade regarding JUnit4.x after years.
We know that the feature "re-run" works other way in both providers and
this has to be well documented for the users.
It would not affect other providers, namely JUnit5, JUnit3 and TestNG.
On Fri, Aug 23, 2019 at 6:47 AM Romain Manni-Bucau <rm...@gmail.com>
wrote:
> Hi Martin,
>
> Here it is fully unrelated but more a setup issue, see previous Tibor's
> answer.
>
> @Tibor: topic was changed do your mailbox didnt see the trick but thread is
> available at
> https://mail-archives.apache.org/mod_mbox/maven-dev/201908.mbox/browser
>
>
> Le ven. 23 août 2019 à 00:45, Tibor Digana <ti...@apache.org> a
> écrit :
>
> > I don't know what Jira issue you are refferring to.
> > The ICL is used due to user's filtering and the multiple fork VMs.
> >
> > On Fri, Aug 23, 2019 at 12:40 AM Martin Gainty <mg...@hotmail.com>
> > wrote:
> >
> > > CNFE when running surefire means
> > > Isolated (TEST) Classloader cannot load the dependency containing that
> > > class
> > > In your case that dependency is junit
> > >
> > > if it was up to me i would discontinue use of Isolated Classloader in
> > > favour of using system classloader
> > > the only reason Isolated cl was used was the path limitation for System
> > > ClassLoader (initially 4k)
> > > now all paths including CLASSPATH can be 32k so restricted classpath
> > > length should not be an issue
> > >
> > > ymmv
> > > martin-
> > >
> > >
> > >
> >
>
Re: Surefire CNFE
Posted by Romain Manni-Bucau <rm...@gmail.com>.
Hi Martin,
Here it is fully unrelated but more a setup issue, see previous Tibor's
answer.
@Tibor: topic was changed do your mailbox didnt see the trick but thread is
available at
https://mail-archives.apache.org/mod_mbox/maven-dev/201908.mbox/browser
Le ven. 23 août 2019 à 00:45, Tibor Digana <ti...@apache.org> a
écrit :
> I don't know what Jira issue you are refferring to.
> The ICL is used due to user's filtering and the multiple fork VMs.
>
> On Fri, Aug 23, 2019 at 12:40 AM Martin Gainty <mg...@hotmail.com>
> wrote:
>
> > CNFE when running surefire means
> > Isolated (TEST) Classloader cannot load the dependency containing that
> > class
> > In your case that dependency is junit
> >
> > if it was up to me i would discontinue use of Isolated Classloader in
> > favour of using system classloader
> > the only reason Isolated cl was used was the path limitation for System
> > ClassLoader (initially 4k)
> > now all paths including CLASSPATH can be 32k so restricted classpath
> > length should not be an issue
> >
> > ymmv
> > martin-
> >
> >
> >
>
Re: Surefire CNFE
Posted by Tibor Digana <ti...@apache.org>.
I don't know what Jira issue you are refferring to.
The ICL is used due to user's filtering and the multiple fork VMs.
On Fri, Aug 23, 2019 at 12:40 AM Martin Gainty <mg...@hotmail.com> wrote:
> CNFE when running surefire means
> Isolated (TEST) Classloader cannot load the dependency containing that
> class
> In your case that dependency is junit
>
> if it was up to me i would discontinue use of Isolated Classloader in
> favour of using system classloader
> the only reason Isolated cl was used was the path limitation for System
> ClassLoader (initially 4k)
> now all paths including CLASSPATH can be 32k so restricted classpath
> length should not be an issue
>
> ymmv
> martin-
>
>
>
Re: Surefire CNFE
Posted by Martin Gainty <mg...@hotmail.com>.
CNFE when running surefire means
Isolated (TEST) Classloader cannot load the dependency containing that class
In your case that dependency is junit
if it was up to me i would discontinue use of Isolated Classloader in favour of using system classloader
the only reason Isolated cl was used was the path limitation for System ClassLoader (initially 4k)
now all paths including CLASSPATH can be 32k so restricted classpath length should not be an issue
ymmv
martin-
Re: looking for some volunteer
Posted by Tibor Digana <ti...@apache.org>.
Hi Dejan,
The build fails on
Caused by: java.lang.ClassNotFoundException: org.junit.runner.Computer
It means that we still have few tests which use JUnit 4 library.
This is full log
https://builds.apache.org/job/maven-box/job/maven-surefire/job/SUREFIRE-1494/1/consoleFull
Cheers
T
On Wed, Aug 21, 2019 at 12:38 PM Dejan Stojadinovic <de...@gmail.com>
wrote:
> @Tibor please review https://github.com/apache/maven-surefire/pull/233
>
> On 2019/05/06 13:37:02, Tibor Digana <ti...@apache.org> wrote:
> > Hello Dejan, I am glad that you are back again.
> > yes, feel free. Github is yours.
> > T
> >
> > On Mon, May 6, 2019 at 2:29 PM Dejan Stojadinovic <de...@gmail.com>
> > wrote:
> >
> > > This one slipped slipped though the cracks (I was few weeks off the
> grid
> > > due to traveling). Let me try to push something soon (if it is not too
> > > late).
> > >
> > > On 2019/04/07 01:19:13, Tibor Digana <ti...@apache.org> wrote:
> > > > Hi Dejan,
> > > >
> > > > I almost forgot your email.
> > > > Pls create a PR on GitHub with a little work even if still
> incomplete but
> > > > at least we would not forget it.
> > > > As you can see in [1] we should create release branches and for your
> PR
> > > as
> > > > well.
> > > > [1]: https://github.com/apache/maven-surefire/pull/227
> > > >
> > > > Cheers
> > > > Tibor
> > > >
> > > >
> > > > On Tue, Mar 26, 2019 at 9:24 AM Dejan Stojadinovic <
> dejan2609@gmail.com>
> > > > wrote:
> > > >
> > > > > Thanx Tibor, I left short comments on JIRA issues (just to mark
> them).
> > > > > I hope I will squeeze first github PR in a few days.
> > > > >
> > > > > Regards,
> > > > > Dejan
> > > > >
> > > > > On 2019/03/24 23:19:08, Tibor Digana <ti...@apache.org>
> wrote:
> > > > > > Hi Dejan,
> > > > > >
> > > > > > Good to hear. In our Jira are two issues related to my original
> > > email:
> > > > > > https://issues.apache.org/jira/browse/SUREFIRE-1654
> > > > > > https://issues.apache.org/jira/browse/SUREFIRE-1494
> > > > > > If you have any questions, feel free to ask here.
> > > > > > Pls run the build locally (mvn -P run-its install) until our
> TravisCI
> > > > > build
> > > > > > would be ready for you. The build takes cca 1 hour to complete.
> > > > > > We should solve these two issue in two separate pull requests.
> > > > > > I guess these tasks require very good preparation and analysis
> of ITs
> > > > > > before making any changes.
> > > > > >
> > > > > > @Enrico can you pls investigate TravisCI, why it still behaves so
> > > much
> > > > > > differently from Jenkins CI and fails?
> > > > > > Is it really due to the deployed SNAPSHOT versions at ASF Nexus?
> > > > > >
> > > > > > Thx
> > > > > >
> > > > > > Cheers
> > > > > > Tibor
> > > > > >
> > > > > >
> > > > > > On Sun, Mar 24, 2019 at 3:23 PM Dejan Stojadinovic <
> > > dejan2609@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Hi Tibor,
> > > > > > >
> > > > > > > I volunteer for this. I have a solid experience with maven
> usage
> > > and
> > > > > also
> > > > > > > contributed few (easy) maven commits:
> > > > > > > https://github.com/apache/maven/commits?author=dejan2609
> > > > > > >
> > > > > > > Regards,
> > > > > > > Dejan Stojadinović
> > > > > > >
> > > > > > > On 2019/03/23 21:47:04, Tibor Digana <ti...@apache.org>
> > > wrote:
> > > > > > > > It's going to be very pedant work for someone who want to
> help
> > > us in
> > > > > > > > Surefire.
> > > > > > > >
> > > > > > > > I am looking for some volunteer who will remove the
> deprecated
> > > config
> > > > > > > param
> > > > > > > > `forkMode` in favor of `forkCount`. All our ITs should use
> > > > > `forkCount`
> > > > > > > > since then.
> > > > > > > >
> > > > > > > > Additionally, the volunteer should deprecate
> `surefire-junit4`
> > > > > provider.
> > > > > > > > Instead `surefire-junit47` provider should be selected as
> default
> > > > > > > provider
> > > > > > > > for JUnit4 tests. Again the ITs should be changed and plugin
> > > > > dependencies
> > > > > > > > should use `surefire-junit4` provider in place where it was
> not
> > > > > > > specified.
> > > > > > > >
> > > > > > > > It's easy to do. When you see the usages of `.forkMode()`
> method
> > > -
> > > > > only
> > > > > > > 20
> > > > > > > > in `surefire-its` and 43 usages of `<forkMode>` in
> > > > > > > > `surefire-its/src/test/resources`.
> > > > > > > >
> > > > > > > > Successful build must prove that the changes have been
> applied
> > > > > correctly.
> > > > > > > > The changes should be in a pull request on GitHub.
> > > > > > > >
> > > > > > > > Cheers
> > > > > > > > Tibor
> > > > > > > >
> > > > > > >
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > >
> > > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: looking for some volunteer
Posted by Tibor Digana <ti...@apache.org>.
Do not worry, we will prepare a branch and trigger the build process.
That's the best indicator that everything went alright.
On Wed, Aug 21, 2019 at 12:38 PM Dejan Stojadinovic <de...@gmail.com>
wrote:
> @Tibor please review https://github.com/apache/maven-surefire/pull/233
>
> On 2019/05/06 13:37:02, Tibor Digana <ti...@apache.org> wrote:
> > Hello Dejan, I am glad that you are back again.
> > yes, feel free. Github is yours.
> > T
> >
> > On Mon, May 6, 2019 at 2:29 PM Dejan Stojadinovic <de...@gmail.com>
> > wrote:
> >
> > > This one slipped slipped though the cracks (I was few weeks off the
> grid
> > > due to traveling). Let me try to push something soon (if it is not too
> > > late).
> > >
> > > On 2019/04/07 01:19:13, Tibor Digana <ti...@apache.org> wrote:
> > > > Hi Dejan,
> > > >
> > > > I almost forgot your email.
> > > > Pls create a PR on GitHub with a little work even if still
> incomplete but
> > > > at least we would not forget it.
> > > > As you can see in [1] we should create release branches and for your
> PR
> > > as
> > > > well.
> > > > [1]: https://github.com/apache/maven-surefire/pull/227
> > > >
> > > > Cheers
> > > > Tibor
> > > >
> > > >
> > > > On Tue, Mar 26, 2019 at 9:24 AM Dejan Stojadinovic <
> dejan2609@gmail.com>
> > > > wrote:
> > > >
> > > > > Thanx Tibor, I left short comments on JIRA issues (just to mark
> them).
> > > > > I hope I will squeeze first github PR in a few days.
> > > > >
> > > > > Regards,
> > > > > Dejan
> > > > >
> > > > > On 2019/03/24 23:19:08, Tibor Digana <ti...@apache.org>
> wrote:
> > > > > > Hi Dejan,
> > > > > >
> > > > > > Good to hear. In our Jira are two issues related to my original
> > > email:
> > > > > > https://issues.apache.org/jira/browse/SUREFIRE-1654
> > > > > > https://issues.apache.org/jira/browse/SUREFIRE-1494
> > > > > > If you have any questions, feel free to ask here.
> > > > > > Pls run the build locally (mvn -P run-its install) until our
> TravisCI
> > > > > build
> > > > > > would be ready for you. The build takes cca 1 hour to complete.
> > > > > > We should solve these two issue in two separate pull requests.
> > > > > > I guess these tasks require very good preparation and analysis
> of ITs
> > > > > > before making any changes.
> > > > > >
> > > > > > @Enrico can you pls investigate TravisCI, why it still behaves so
> > > much
> > > > > > differently from Jenkins CI and fails?
> > > > > > Is it really due to the deployed SNAPSHOT versions at ASF Nexus?
> > > > > >
> > > > > > Thx
> > > > > >
> > > > > > Cheers
> > > > > > Tibor
> > > > > >
> > > > > >
> > > > > > On Sun, Mar 24, 2019 at 3:23 PM Dejan Stojadinovic <
> > > dejan2609@gmail.com>
> > > > > > wrote:
> > > > > >
> > > > > > > Hi Tibor,
> > > > > > >
> > > > > > > I volunteer for this. I have a solid experience with maven
> usage
> > > and
> > > > > also
> > > > > > > contributed few (easy) maven commits:
> > > > > > > https://github.com/apache/maven/commits?author=dejan2609
> > > > > > >
> > > > > > > Regards,
> > > > > > > Dejan Stojadinović
> > > > > > >
> > > > > > > On 2019/03/23 21:47:04, Tibor Digana <ti...@apache.org>
> > > wrote:
> > > > > > > > It's going to be very pedant work for someone who want to
> help
> > > us in
> > > > > > > > Surefire.
> > > > > > > >
> > > > > > > > I am looking for some volunteer who will remove the
> deprecated
> > > config
> > > > > > > param
> > > > > > > > `forkMode` in favor of `forkCount`. All our ITs should use
> > > > > `forkCount`
> > > > > > > > since then.
> > > > > > > >
> > > > > > > > Additionally, the volunteer should deprecate
> `surefire-junit4`
> > > > > provider.
> > > > > > > > Instead `surefire-junit47` provider should be selected as
> default
> > > > > > > provider
> > > > > > > > for JUnit4 tests. Again the ITs should be changed and plugin
> > > > > dependencies
> > > > > > > > should use `surefire-junit4` provider in place where it was
> not
> > > > > > > specified.
> > > > > > > >
> > > > > > > > It's easy to do. When you see the usages of `.forkMode()`
> method
> > > -
> > > > > only
> > > > > > > 20
> > > > > > > > in `surefire-its` and 43 usages of `<forkMode>` in
> > > > > > > > `surefire-its/src/test/resources`.
> > > > > > > >
> > > > > > > > Successful build must prove that the changes have been
> applied
> > > > > correctly.
> > > > > > > > The changes should be in a pull request on GitHub.
> > > > > > > >
> > > > > > > > Cheers
> > > > > > > > Tibor
> > > > > > > >
> > > > > > >
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > >
> > > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: looking for some volunteer
Posted by Dejan Stojadinovic <de...@gmail.com>.
@Tibor please review https://github.com/apache/maven-surefire/pull/233
On 2019/05/06 13:37:02, Tibor Digana <ti...@apache.org> wrote:
> Hello Dejan, I am glad that you are back again.
> yes, feel free. Github is yours.
> T
>
> On Mon, May 6, 2019 at 2:29 PM Dejan Stojadinovic <de...@gmail.com>
> wrote:
>
> > This one slipped slipped though the cracks (I was few weeks off the grid
> > due to traveling). Let me try to push something soon (if it is not too
> > late).
> >
> > On 2019/04/07 01:19:13, Tibor Digana <ti...@apache.org> wrote:
> > > Hi Dejan,
> > >
> > > I almost forgot your email.
> > > Pls create a PR on GitHub with a little work even if still incomplete but
> > > at least we would not forget it.
> > > As you can see in [1] we should create release branches and for your PR
> > as
> > > well.
> > > [1]: https://github.com/apache/maven-surefire/pull/227
> > >
> > > Cheers
> > > Tibor
> > >
> > >
> > > On Tue, Mar 26, 2019 at 9:24 AM Dejan Stojadinovic <de...@gmail.com>
> > > wrote:
> > >
> > > > Thanx Tibor, I left short comments on JIRA issues (just to mark them).
> > > > I hope I will squeeze first github PR in a few days.
> > > >
> > > > Regards,
> > > > Dejan
> > > >
> > > > On 2019/03/24 23:19:08, Tibor Digana <ti...@apache.org> wrote:
> > > > > Hi Dejan,
> > > > >
> > > > > Good to hear. In our Jira are two issues related to my original
> > email:
> > > > > https://issues.apache.org/jira/browse/SUREFIRE-1654
> > > > > https://issues.apache.org/jira/browse/SUREFIRE-1494
> > > > > If you have any questions, feel free to ask here.
> > > > > Pls run the build locally (mvn -P run-its install) until our TravisCI
> > > > build
> > > > > would be ready for you. The build takes cca 1 hour to complete.
> > > > > We should solve these two issue in two separate pull requests.
> > > > > I guess these tasks require very good preparation and analysis of ITs
> > > > > before making any changes.
> > > > >
> > > > > @Enrico can you pls investigate TravisCI, why it still behaves so
> > much
> > > > > differently from Jenkins CI and fails?
> > > > > Is it really due to the deployed SNAPSHOT versions at ASF Nexus?
> > > > >
> > > > > Thx
> > > > >
> > > > > Cheers
> > > > > Tibor
> > > > >
> > > > >
> > > > > On Sun, Mar 24, 2019 at 3:23 PM Dejan Stojadinovic <
> > dejan2609@gmail.com>
> > > > > wrote:
> > > > >
> > > > > > Hi Tibor,
> > > > > >
> > > > > > I volunteer for this. I have a solid experience with maven usage
> > and
> > > > also
> > > > > > contributed few (easy) maven commits:
> > > > > > https://github.com/apache/maven/commits?author=dejan2609
> > > > > >
> > > > > > Regards,
> > > > > > Dejan Stojadinović
> > > > > >
> > > > > > On 2019/03/23 21:47:04, Tibor Digana <ti...@apache.org>
> > wrote:
> > > > > > > It's going to be very pedant work for someone who want to help
> > us in
> > > > > > > Surefire.
> > > > > > >
> > > > > > > I am looking for some volunteer who will remove the deprecated
> > config
> > > > > > param
> > > > > > > `forkMode` in favor of `forkCount`. All our ITs should use
> > > > `forkCount`
> > > > > > > since then.
> > > > > > >
> > > > > > > Additionally, the volunteer should deprecate `surefire-junit4`
> > > > provider.
> > > > > > > Instead `surefire-junit47` provider should be selected as default
> > > > > > provider
> > > > > > > for JUnit4 tests. Again the ITs should be changed and plugin
> > > > dependencies
> > > > > > > should use `surefire-junit4` provider in place where it was not
> > > > > > specified.
> > > > > > >
> > > > > > > It's easy to do. When you see the usages of `.forkMode()` method
> > -
> > > > only
> > > > > > 20
> > > > > > > in `surefire-its` and 43 usages of `<forkMode>` in
> > > > > > > `surefire-its/src/test/resources`.
> > > > > > >
> > > > > > > Successful build must prove that the changes have been applied
> > > > correctly.
> > > > > > > The changes should be in a pull request on GitHub.
> > > > > > >
> > > > > > > Cheers
> > > > > > > Tibor
> > > > > > >
> > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > > >
> > > > > >
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > >
> > > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: looking for some volunteer
Posted by Tibor Digana <ti...@apache.org>.
Hello Dejan, I am glad that you are back again.
yes, feel free. Github is yours.
T
On Mon, May 6, 2019 at 2:29 PM Dejan Stojadinovic <de...@gmail.com>
wrote:
> This one slipped slipped though the cracks (I was few weeks off the grid
> due to traveling). Let me try to push something soon (if it is not too
> late).
>
> On 2019/04/07 01:19:13, Tibor Digana <ti...@apache.org> wrote:
> > Hi Dejan,
> >
> > I almost forgot your email.
> > Pls create a PR on GitHub with a little work even if still incomplete but
> > at least we would not forget it.
> > As you can see in [1] we should create release branches and for your PR
> as
> > well.
> > [1]: https://github.com/apache/maven-surefire/pull/227
> >
> > Cheers
> > Tibor
> >
> >
> > On Tue, Mar 26, 2019 at 9:24 AM Dejan Stojadinovic <de...@gmail.com>
> > wrote:
> >
> > > Thanx Tibor, I left short comments on JIRA issues (just to mark them).
> > > I hope I will squeeze first github PR in a few days.
> > >
> > > Regards,
> > > Dejan
> > >
> > > On 2019/03/24 23:19:08, Tibor Digana <ti...@apache.org> wrote:
> > > > Hi Dejan,
> > > >
> > > > Good to hear. In our Jira are two issues related to my original
> email:
> > > > https://issues.apache.org/jira/browse/SUREFIRE-1654
> > > > https://issues.apache.org/jira/browse/SUREFIRE-1494
> > > > If you have any questions, feel free to ask here.
> > > > Pls run the build locally (mvn -P run-its install) until our TravisCI
> > > build
> > > > would be ready for you. The build takes cca 1 hour to complete.
> > > > We should solve these two issue in two separate pull requests.
> > > > I guess these tasks require very good preparation and analysis of ITs
> > > > before making any changes.
> > > >
> > > > @Enrico can you pls investigate TravisCI, why it still behaves so
> much
> > > > differently from Jenkins CI and fails?
> > > > Is it really due to the deployed SNAPSHOT versions at ASF Nexus?
> > > >
> > > > Thx
> > > >
> > > > Cheers
> > > > Tibor
> > > >
> > > >
> > > > On Sun, Mar 24, 2019 at 3:23 PM Dejan Stojadinovic <
> dejan2609@gmail.com>
> > > > wrote:
> > > >
> > > > > Hi Tibor,
> > > > >
> > > > > I volunteer for this. I have a solid experience with maven usage
> and
> > > also
> > > > > contributed few (easy) maven commits:
> > > > > https://github.com/apache/maven/commits?author=dejan2609
> > > > >
> > > > > Regards,
> > > > > Dejan Stojadinović
> > > > >
> > > > > On 2019/03/23 21:47:04, Tibor Digana <ti...@apache.org>
> wrote:
> > > > > > It's going to be very pedant work for someone who want to help
> us in
> > > > > > Surefire.
> > > > > >
> > > > > > I am looking for some volunteer who will remove the deprecated
> config
> > > > > param
> > > > > > `forkMode` in favor of `forkCount`. All our ITs should use
> > > `forkCount`
> > > > > > since then.
> > > > > >
> > > > > > Additionally, the volunteer should deprecate `surefire-junit4`
> > > provider.
> > > > > > Instead `surefire-junit47` provider should be selected as default
> > > > > provider
> > > > > > for JUnit4 tests. Again the ITs should be changed and plugin
> > > dependencies
> > > > > > should use `surefire-junit4` provider in place where it was not
> > > > > specified.
> > > > > >
> > > > > > It's easy to do. When you see the usages of `.forkMode()` method
> -
> > > only
> > > > > 20
> > > > > > in `surefire-its` and 43 usages of `<forkMode>` in
> > > > > > `surefire-its/src/test/resources`.
> > > > > >
> > > > > > Successful build must prove that the changes have been applied
> > > correctly.
> > > > > > The changes should be in a pull request on GitHub.
> > > > > >
> > > > > > Cheers
> > > > > > Tibor
> > > > > >
> > > > >
> > > > >
> ---------------------------------------------------------------------
> > > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > > >
> > > > >
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: looking for some volunteer
Posted by Dejan Stojadinovic <de...@gmail.com>.
This one slipped slipped though the cracks (I was few weeks off the grid due to traveling). Let me try to push something soon (if it is not too late).
On 2019/04/07 01:19:13, Tibor Digana <ti...@apache.org> wrote:
> Hi Dejan,
>
> I almost forgot your email.
> Pls create a PR on GitHub with a little work even if still incomplete but
> at least we would not forget it.
> As you can see in [1] we should create release branches and for your PR as
> well.
> [1]: https://github.com/apache/maven-surefire/pull/227
>
> Cheers
> Tibor
>
>
> On Tue, Mar 26, 2019 at 9:24 AM Dejan Stojadinovic <de...@gmail.com>
> wrote:
>
> > Thanx Tibor, I left short comments on JIRA issues (just to mark them).
> > I hope I will squeeze first github PR in a few days.
> >
> > Regards,
> > Dejan
> >
> > On 2019/03/24 23:19:08, Tibor Digana <ti...@apache.org> wrote:
> > > Hi Dejan,
> > >
> > > Good to hear. In our Jira are two issues related to my original email:
> > > https://issues.apache.org/jira/browse/SUREFIRE-1654
> > > https://issues.apache.org/jira/browse/SUREFIRE-1494
> > > If you have any questions, feel free to ask here.
> > > Pls run the build locally (mvn -P run-its install) until our TravisCI
> > build
> > > would be ready for you. The build takes cca 1 hour to complete.
> > > We should solve these two issue in two separate pull requests.
> > > I guess these tasks require very good preparation and analysis of ITs
> > > before making any changes.
> > >
> > > @Enrico can you pls investigate TravisCI, why it still behaves so much
> > > differently from Jenkins CI and fails?
> > > Is it really due to the deployed SNAPSHOT versions at ASF Nexus?
> > >
> > > Thx
> > >
> > > Cheers
> > > Tibor
> > >
> > >
> > > On Sun, Mar 24, 2019 at 3:23 PM Dejan Stojadinovic <de...@gmail.com>
> > > wrote:
> > >
> > > > Hi Tibor,
> > > >
> > > > I volunteer for this. I have a solid experience with maven usage and
> > also
> > > > contributed few (easy) maven commits:
> > > > https://github.com/apache/maven/commits?author=dejan2609
> > > >
> > > > Regards,
> > > > Dejan Stojadinović
> > > >
> > > > On 2019/03/23 21:47:04, Tibor Digana <ti...@apache.org> wrote:
> > > > > It's going to be very pedant work for someone who want to help us in
> > > > > Surefire.
> > > > >
> > > > > I am looking for some volunteer who will remove the deprecated config
> > > > param
> > > > > `forkMode` in favor of `forkCount`. All our ITs should use
> > `forkCount`
> > > > > since then.
> > > > >
> > > > > Additionally, the volunteer should deprecate `surefire-junit4`
> > provider.
> > > > > Instead `surefire-junit47` provider should be selected as default
> > > > provider
> > > > > for JUnit4 tests. Again the ITs should be changed and plugin
> > dependencies
> > > > > should use `surefire-junit4` provider in place where it was not
> > > > specified.
> > > > >
> > > > > It's easy to do. When you see the usages of `.forkMode()` method -
> > only
> > > > 20
> > > > > in `surefire-its` and 43 usages of `<forkMode>` in
> > > > > `surefire-its/src/test/resources`.
> > > > >
> > > > > Successful build must prove that the changes have been applied
> > correctly.
> > > > > The changes should be in a pull request on GitHub.
> > > > >
> > > > > Cheers
> > > > > Tibor
> > > > >
> > > >
> > > > ---------------------------------------------------------------------
> > > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > > For additional commands, e-mail: dev-help@maven.apache.org
> > > >
> > > >
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: looking for some volunteer
Posted by Tibor Digana <ti...@apache.org>.
Hi Dejan,
I almost forgot your email.
Pls create a PR on GitHub with a little work even if still incomplete but
at least we would not forget it.
As you can see in [1] we should create release branches and for your PR as
well.
[1]: https://github.com/apache/maven-surefire/pull/227
Cheers
Tibor
On Tue, Mar 26, 2019 at 9:24 AM Dejan Stojadinovic <de...@gmail.com>
wrote:
> Thanx Tibor, I left short comments on JIRA issues (just to mark them).
> I hope I will squeeze first github PR in a few days.
>
> Regards,
> Dejan
>
> On 2019/03/24 23:19:08, Tibor Digana <ti...@apache.org> wrote:
> > Hi Dejan,
> >
> > Good to hear. In our Jira are two issues related to my original email:
> > https://issues.apache.org/jira/browse/SUREFIRE-1654
> > https://issues.apache.org/jira/browse/SUREFIRE-1494
> > If you have any questions, feel free to ask here.
> > Pls run the build locally (mvn -P run-its install) until our TravisCI
> build
> > would be ready for you. The build takes cca 1 hour to complete.
> > We should solve these two issue in two separate pull requests.
> > I guess these tasks require very good preparation and analysis of ITs
> > before making any changes.
> >
> > @Enrico can you pls investigate TravisCI, why it still behaves so much
> > differently from Jenkins CI and fails?
> > Is it really due to the deployed SNAPSHOT versions at ASF Nexus?
> >
> > Thx
> >
> > Cheers
> > Tibor
> >
> >
> > On Sun, Mar 24, 2019 at 3:23 PM Dejan Stojadinovic <de...@gmail.com>
> > wrote:
> >
> > > Hi Tibor,
> > >
> > > I volunteer for this. I have a solid experience with maven usage and
> also
> > > contributed few (easy) maven commits:
> > > https://github.com/apache/maven/commits?author=dejan2609
> > >
> > > Regards,
> > > Dejan Stojadinović
> > >
> > > On 2019/03/23 21:47:04, Tibor Digana <ti...@apache.org> wrote:
> > > > It's going to be very pedant work for someone who want to help us in
> > > > Surefire.
> > > >
> > > > I am looking for some volunteer who will remove the deprecated config
> > > param
> > > > `forkMode` in favor of `forkCount`. All our ITs should use
> `forkCount`
> > > > since then.
> > > >
> > > > Additionally, the volunteer should deprecate `surefire-junit4`
> provider.
> > > > Instead `surefire-junit47` provider should be selected as default
> > > provider
> > > > for JUnit4 tests. Again the ITs should be changed and plugin
> dependencies
> > > > should use `surefire-junit4` provider in place where it was not
> > > specified.
> > > >
> > > > It's easy to do. When you see the usages of `.forkMode()` method -
> only
> > > 20
> > > > in `surefire-its` and 43 usages of `<forkMode>` in
> > > > `surefire-its/src/test/resources`.
> > > >
> > > > Successful build must prove that the changes have been applied
> correctly.
> > > > The changes should be in a pull request on GitHub.
> > > >
> > > > Cheers
> > > > Tibor
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: looking for some volunteer
Posted by Tibor Digana <ti...@apache.org>.
Hi Dejan,
Take your time.
We don't need it in days. We are talking about weeks/months.
I know that we will make code review and the development period would be
prolonged but that's expected.
What is a little bit more important than the time is the quality.
Cheers
Tibor
On Tue, Mar 26, 2019 at 9:24 AM Dejan Stojadinovic <de...@gmail.com>
wrote:
> Thanx Tibor, I left short comments on JIRA issues (just to mark them).
> I hope I will squeeze first github PR in a few days.
>
> Regards,
> Dejan
>
> On 2019/03/24 23:19:08, Tibor Digana <ti...@apache.org> wrote:
> > Hi Dejan,
> >
> > Good to hear. In our Jira are two issues related to my original email:
> > https://issues.apache.org/jira/browse/SUREFIRE-1654
> > https://issues.apache.org/jira/browse/SUREFIRE-1494
> > If you have any questions, feel free to ask here.
> > Pls run the build locally (mvn -P run-its install) until our TravisCI
> build
> > would be ready for you. The build takes cca 1 hour to complete.
> > We should solve these two issue in two separate pull requests.
> > I guess these tasks require very good preparation and analysis of ITs
> > before making any changes.
> >
> > @Enrico can you pls investigate TravisCI, why it still behaves so much
> > differently from Jenkins CI and fails?
> > Is it really due to the deployed SNAPSHOT versions at ASF Nexus?
> >
> > Thx
> >
> > Cheers
> > Tibor
> >
> >
> > On Sun, Mar 24, 2019 at 3:23 PM Dejan Stojadinovic <de...@gmail.com>
> > wrote:
> >
> > > Hi Tibor,
> > >
> > > I volunteer for this. I have a solid experience with maven usage and
> also
> > > contributed few (easy) maven commits:
> > > https://github.com/apache/maven/commits?author=dejan2609
> > >
> > > Regards,
> > > Dejan Stojadinović
> > >
> > > On 2019/03/23 21:47:04, Tibor Digana <ti...@apache.org> wrote:
> > > > It's going to be very pedant work for someone who want to help us in
> > > > Surefire.
> > > >
> > > > I am looking for some volunteer who will remove the deprecated config
> > > param
> > > > `forkMode` in favor of `forkCount`. All our ITs should use
> `forkCount`
> > > > since then.
> > > >
> > > > Additionally, the volunteer should deprecate `surefire-junit4`
> provider.
> > > > Instead `surefire-junit47` provider should be selected as default
> > > provider
> > > > for JUnit4 tests. Again the ITs should be changed and plugin
> dependencies
> > > > should use `surefire-junit4` provider in place where it was not
> > > specified.
> > > >
> > > > It's easy to do. When you see the usages of `.forkMode()` method -
> only
> > > 20
> > > > in `surefire-its` and 43 usages of `<forkMode>` in
> > > > `surefire-its/src/test/resources`.
> > > >
> > > > Successful build must prove that the changes have been applied
> correctly.
> > > > The changes should be in a pull request on GitHub.
> > > >
> > > > Cheers
> > > > Tibor
> > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > > For additional commands, e-mail: dev-help@maven.apache.org
> > >
> > >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: looking for some volunteer
Posted by Dejan Stojadinovic <de...@gmail.com>.
Thanx Tibor, I left short comments on JIRA issues (just to mark them).
I hope I will squeeze first github PR in a few days.
Regards,
Dejan
On 2019/03/24 23:19:08, Tibor Digana <ti...@apache.org> wrote:
> Hi Dejan,
>
> Good to hear. In our Jira are two issues related to my original email:
> https://issues.apache.org/jira/browse/SUREFIRE-1654
> https://issues.apache.org/jira/browse/SUREFIRE-1494
> If you have any questions, feel free to ask here.
> Pls run the build locally (mvn -P run-its install) until our TravisCI build
> would be ready for you. The build takes cca 1 hour to complete.
> We should solve these two issue in two separate pull requests.
> I guess these tasks require very good preparation and analysis of ITs
> before making any changes.
>
> @Enrico can you pls investigate TravisCI, why it still behaves so much
> differently from Jenkins CI and fails?
> Is it really due to the deployed SNAPSHOT versions at ASF Nexus?
>
> Thx
>
> Cheers
> Tibor
>
>
> On Sun, Mar 24, 2019 at 3:23 PM Dejan Stojadinovic <de...@gmail.com>
> wrote:
>
> > Hi Tibor,
> >
> > I volunteer for this. I have a solid experience with maven usage and also
> > contributed few (easy) maven commits:
> > https://github.com/apache/maven/commits?author=dejan2609
> >
> > Regards,
> > Dejan Stojadinović
> >
> > On 2019/03/23 21:47:04, Tibor Digana <ti...@apache.org> wrote:
> > > It's going to be very pedant work for someone who want to help us in
> > > Surefire.
> > >
> > > I am looking for some volunteer who will remove the deprecated config
> > param
> > > `forkMode` in favor of `forkCount`. All our ITs should use `forkCount`
> > > since then.
> > >
> > > Additionally, the volunteer should deprecate `surefire-junit4` provider.
> > > Instead `surefire-junit47` provider should be selected as default
> > provider
> > > for JUnit4 tests. Again the ITs should be changed and plugin dependencies
> > > should use `surefire-junit4` provider in place where it was not
> > specified.
> > >
> > > It's easy to do. When you see the usages of `.forkMode()` method - only
> > 20
> > > in `surefire-its` and 43 usages of `<forkMode>` in
> > > `surefire-its/src/test/resources`.
> > >
> > > Successful build must prove that the changes have been applied correctly.
> > > The changes should be in a pull request on GitHub.
> > >
> > > Cheers
> > > Tibor
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> > For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: looking for some volunteer
Posted by Tibor Digana <ti...@apache.org>.
Hi Dejan,
Good to hear. In our Jira are two issues related to my original email:
https://issues.apache.org/jira/browse/SUREFIRE-1654
https://issues.apache.org/jira/browse/SUREFIRE-1494
If you have any questions, feel free to ask here.
Pls run the build locally (mvn -P run-its install) until our TravisCI build
would be ready for you. The build takes cca 1 hour to complete.
We should solve these two issue in two separate pull requests.
I guess these tasks require very good preparation and analysis of ITs
before making any changes.
@Enrico can you pls investigate TravisCI, why it still behaves so much
differently from Jenkins CI and fails?
Is it really due to the deployed SNAPSHOT versions at ASF Nexus?
Thx
Cheers
Tibor
On Sun, Mar 24, 2019 at 3:23 PM Dejan Stojadinovic <de...@gmail.com>
wrote:
> Hi Tibor,
>
> I volunteer for this. I have a solid experience with maven usage and also
> contributed few (easy) maven commits:
> https://github.com/apache/maven/commits?author=dejan2609
>
> Regards,
> Dejan Stojadinović
>
> On 2019/03/23 21:47:04, Tibor Digana <ti...@apache.org> wrote:
> > It's going to be very pedant work for someone who want to help us in
> > Surefire.
> >
> > I am looking for some volunteer who will remove the deprecated config
> param
> > `forkMode` in favor of `forkCount`. All our ITs should use `forkCount`
> > since then.
> >
> > Additionally, the volunteer should deprecate `surefire-junit4` provider.
> > Instead `surefire-junit47` provider should be selected as default
> provider
> > for JUnit4 tests. Again the ITs should be changed and plugin dependencies
> > should use `surefire-junit4` provider in place where it was not
> specified.
> >
> > It's easy to do. When you see the usages of `.forkMode()` method - only
> 20
> > in `surefire-its` and 43 usages of `<forkMode>` in
> > `surefire-its/src/test/resources`.
> >
> > Successful build must prove that the changes have been applied correctly.
> > The changes should be in a pull request on GitHub.
> >
> > Cheers
> > Tibor
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
Re: looking for some volunteer
Posted by Dejan Stojadinovic <de...@gmail.com>.
Hi Tibor,
I volunteer for this. I have a solid experience with maven usage and also contributed few (easy) maven commits: https://github.com/apache/maven/commits?author=dejan2609
Regards,
Dejan Stojadinović
On 2019/03/23 21:47:04, Tibor Digana <ti...@apache.org> wrote:
> It's going to be very pedant work for someone who want to help us in
> Surefire.
>
> I am looking for some volunteer who will remove the deprecated config param
> `forkMode` in favor of `forkCount`. All our ITs should use `forkCount`
> since then.
>
> Additionally, the volunteer should deprecate `surefire-junit4` provider.
> Instead `surefire-junit47` provider should be selected as default provider
> for JUnit4 tests. Again the ITs should be changed and plugin dependencies
> should use `surefire-junit4` provider in place where it was not specified.
>
> It's easy to do. When you see the usages of `.forkMode()` method - only 20
> in `surefire-its` and 43 usages of `<forkMode>` in
> `surefire-its/src/test/resources`.
>
> Successful build must prove that the changes have been applied correctly.
> The changes should be in a pull request on GitHub.
>
> Cheers
> Tibor
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org