Re: Review Request 15110: Moving the BlobDeserializer from Morphline Sink to flume-ng-core/.../serialization

[Roshan Naik <ro...@hortonworks.com>]

> On Oct. 31, 2013, 6:20 a.m., Hari Shreedharan wrote:
> > A better solution would be to have this class inherit the class that implements this (where this class was moved to). In that case this is guaranteed to be backward compatible too.

Yes. I should have thought of that!


> On Oct. 31, 2013, 6:20 a.m., Hari Shreedharan wrote:
> > flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobDeserializer.java, lines 153-164
> > <https://reviews.apache.org/r/15110/diff/1/?file=374543#file374543line153>
> >
> >     This code too is a bit of a problem:
> >     
> >     Any code that looks like this would fail:
> >     
> >     org.apache.flume.sink.solr.morphline.BlobSerializer s = BlobSerializer.Builder.build();
> >     
> >     Though we don't have any classes that do that this will be a problem.

Indeed. But I think we probably do not need to support that code in this fix. As the class is annotated '@InterfaceAudience.Private' and we dont want to support new code that wants to do that kind of a thing.


- Roshan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/15110/#review27862
-----------------------------------------------------------


On Oct. 31, 2013, 12:52 a.m., Roshan Naik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/15110/
> -----------------------------------------------------------
> 
> (Updated Oct. 31, 2013, 12:52 a.m.)
> 
> 
> Review request for Flume.
> 
> 
> Bugs: FLUME-2227
>     https://issues.apache.org/jira/browse/FLUME-2227
> 
> 
> Repository: flume-git
> 
> 
> Description
> -------
> 
> - Moved BlobDeserializer out of morphline sink and into core/.../serialization along with tests. 
> - Updated docs to reflect new FQCN
> - Retained dummy class for old FQCN compat
> 
> 
> Diffs
> -----
> 
>   flume-ng-core/src/main/java/org/apache/flume/serialization/BlobDeserializer.java PRE-CREATION 
>   flume-ng-core/src/test/java/org/apache/flume/serialization/ResettableTestByteInputStream.java PRE-CREATION 
>   flume-ng-core/src/test/java/org/apache/flume/serialization/TestBlobDeserializer.java PRE-CREATION 
>   flume-ng-doc/sphinx/FlumeUserGuide.rst e38bb67 
>   flume-ng-sinks/flume-ng-morphline-solr-sink/src/main/java/org/apache/flume/sink/solr/morphline/BlobDeserializer.java 12bdc40 
>   flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/ResettableTestStringInputStream.java e6ee9b9 
>   flume-ng-sinks/flume-ng-morphline-solr-sink/src/test/java/org/apache/flume/sink/solr/morphline/TestBlobDeserializer.java 6172c68 
> 
> Diff: https://reviews.apache.org/r/15110/diff/
> 
> 
> Testing
> -------
> 
> unit tests
> 
> 
> Thanks,
> 
> Roshan Naik
> 
>