You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sylvain Lebresne (Created) (JIRA)" <ji...@apache.org> on 2011/11/08 11:36:51 UTC
[jira] [Created] (CASSANDRA-3472) Actually uses efficient cross DC
writes
Actually uses efficient cross DC writes
---------------------------------------
Key: CASSANDRA-3472
URL: https://issues.apache.org/jira/browse/CASSANDRA-3472
Project: Cassandra
Issue Type: Bug
Components: Core
Affects Versions: 0.7.1
Reporter: Sylvain Lebresne
Assignee: Sylvain Lebresne
Priority: Minor
Fix For: 0.8.8, 1.0.3
CASSANDRA-2138 introduced the following code:
{noformat}
if (dataCenter.equals(localDataCenter) || StorageService.instance.useEfficientCrossDCWrites())
{
// direct writes to local DC or old Cassadra versions
for (InetAddress destination : messages.getValue())
MessagingService.instance().sendRR(message, destination, handler);
}
else
{
// Non-local DC. First endpoint in list is the destination for this group
{noformat}
A 'not' is missing on that useEfficientCrossDCWrites call (which does return true for any version >= 0.7.1).
A simple fix would be to add the missing !, but as said a comment, all this code should have been removed in 0.8 since it was detecting nodes before 0.7.1, but direct upgrade from pre-0.7.1 to 0.8+ is not supported. So let's just completely remove that code now.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3472) Actually uses efficient cross
DC writes
Posted by "Jonathan Ellis (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146349#comment-13146349 ]
Jonathan Ellis commented on CASSANDRA-3472:
-------------------------------------------
+1
> Actually uses efficient cross DC writes
> ---------------------------------------
>
> Key: CASSANDRA-3472
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3472
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.1
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 0.8.8, 1.0.3
>
> Attachments: 3472.patch
>
>
> CASSANDRA-2138 introduced the following code:
> {noformat}
> if (dataCenter.equals(localDataCenter) || StorageService.instance.useEfficientCrossDCWrites())
> {
> // direct writes to local DC or old Cassadra versions
> for (InetAddress destination : messages.getValue())
> MessagingService.instance().sendRR(message, destination, handler);
> }
> else
> {
> // Non-local DC. First endpoint in list is the destination for this group
> {noformat}
> A 'not' is missing on that useEfficientCrossDCWrites call (which does return true for any version >= 0.7.1).
> A simple fix would be to add the missing !, but as said a comment, all this code should have been removed in 0.8 since it was detecting nodes before 0.7.1, but direct upgrade from pre-0.7.1 to 0.8+ is not supported. So let's just completely remove that code now.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-3472) Actually uses efficient cross
DC writes
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13146446#comment-13146446 ]
Hudson commented on CASSANDRA-3472:
-----------------------------------
Integrated in Cassandra-0.8 #396 (See [https://builds.apache.org/job/Cassandra-0.8/396/])
Fix bug preventing the use of efficient cross-DC writes
patch by slebresne; reviewed by jbellis for CASSANDRA-3472
slebresne : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1199284
Files :
* /cassandra/branches/cassandra-0.8/CHANGES.txt
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageProxy.java
* /cassandra/branches/cassandra-0.8/src/java/org/apache/cassandra/service/StorageService.java
> Actually uses efficient cross DC writes
> ---------------------------------------
>
> Key: CASSANDRA-3472
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3472
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.1
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 0.8.8, 1.0.3
>
> Attachments: 3472.patch
>
>
> CASSANDRA-2138 introduced the following code:
> {noformat}
> if (dataCenter.equals(localDataCenter) || StorageService.instance.useEfficientCrossDCWrites())
> {
> // direct writes to local DC or old Cassadra versions
> for (InetAddress destination : messages.getValue())
> MessagingService.instance().sendRR(message, destination, handler);
> }
> else
> {
> // Non-local DC. First endpoint in list is the destination for this group
> {noformat}
> A 'not' is missing on that useEfficientCrossDCWrites call (which does return true for any version >= 0.7.1).
> A simple fix would be to add the missing !, but as said a comment, all this code should have been removed in 0.8 since it was detecting nodes before 0.7.1, but direct upgrade from pre-0.7.1 to 0.8+ is not supported. So let's just completely remove that code now.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-3472) Actually uses efficient cross DC
writes
Posted by "Sylvain Lebresne (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-3472?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sylvain Lebresne updated CASSANDRA-3472:
----------------------------------------
Attachment: 3472.patch
Attached patch is against 0.8
> Actually uses efficient cross DC writes
> ---------------------------------------
>
> Key: CASSANDRA-3472
> URL: https://issues.apache.org/jira/browse/CASSANDRA-3472
> Project: Cassandra
> Issue Type: Bug
> Components: Core
> Affects Versions: 0.7.1
> Reporter: Sylvain Lebresne
> Assignee: Sylvain Lebresne
> Priority: Minor
> Fix For: 0.8.8, 1.0.3
>
> Attachments: 3472.patch
>
>
> CASSANDRA-2138 introduced the following code:
> {noformat}
> if (dataCenter.equals(localDataCenter) || StorageService.instance.useEfficientCrossDCWrites())
> {
> // direct writes to local DC or old Cassadra versions
> for (InetAddress destination : messages.getValue())
> MessagingService.instance().sendRR(message, destination, handler);
> }
> else
> {
> // Non-local DC. First endpoint in list is the destination for this group
> {noformat}
> A 'not' is missing on that useEfficientCrossDCWrites call (which does return true for any version >= 0.7.1).
> A simple fix would be to add the missing !, but as said a comment, all this code should have been removed in 0.8 since it was detecting nodes before 0.7.1, but direct upgrade from pre-0.7.1 to 0.8+ is not supported. So let's just completely remove that code now.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira