You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/12/24 18:02:57 UTC

[GitHub] [kafka] inponomarev commented on pull request #9107: KAFKA-5488: Add type save branch() operator

inponomarev commented on pull request #9107:
URL: https://github.com/apache/kafka/pull/9107#issuecomment-750937120


   Hi @mjsax, thanks for your thorough revew! I have fixed everything according to your comments, except:
   
   * https://github.com/apache/kafka/pull/9107#discussion_r547592368 -- just want to be sure!
   * https://github.com/apache/kafka/pull/9107#discussion_r547606064 -- see my explanation
   * https://github.com/apache/kafka/pull/9107#discussion_r547607739 -- I agree that this is ugly but there was a good reason why I made it this way. Just give me a day and I'll return with comments (or will fix it).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org