You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by IvanKarpan <gi...@git.apache.org> on 2014/12/08 16:26:50 UTC
[GitHub] cordova-ios pull request: CB-6637 - Removed - request:isFragmentId...
GitHub user IvanKarpan opened a pull request:
https://github.com/apache/cordova-ios/pull/121
CB-6637 - Removed - request:isFragmentIdentifierToRequest: deprecated method in CDVWebViewDelegate
Hello,
I know this is a small contribution but I wanted to help and so fixed this bug:
https://issues.apache.org/jira/browse/CB-6637
I just went through the steps here:
http://wiki.apache.org/cordova/ContributorWorkflow
But was not able to assign the issue in JIRA to myself.
Please let me know if I did something incorrectly, if yes - will do better next time. I hope to be more active in Cordova/iOS projects so this is a first step for me.
Best regards,
Ivan Karpan
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/IvanKarpan/cordova-ios master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-ios/pull/121.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #121
----
commit 8f3ef668c604c04030668bab68dfa90c86c7949a
Author: Ivan Karpan <iv...@gmail.com>
Date: 2014-12-08T14:59:21Z
CB-6637 - Removed - request:isFragmentIdentifierToRequest: deprecated
method in CDVWebViewDelegate
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-6637 - Removed - request:isFragmentId...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-ios/pull/121
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-ios pull request: CB-6637 - Removed - request:isFragmentId...
Posted by IvanKarpan <gi...@git.apache.org>.
Github user IvanKarpan commented on the pull request:
https://github.com/apache/cordova-ios/pull/121#issuecomment-66657870
Just FYI I received the acknowledgment regarding my ICLA. So my contribution can be officially reviewed and accepted (or rejected but let me know what I should fix).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org