You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/22 22:03:09 UTC
[GitHub] [airflow] potiuk opened a new pull request, #25886: Limit Google Protobuf for compatibility with biggtable client
potiuk opened a new pull request, #25886:
URL: https://github.com/apache/airflow/pull/25886
The bigtable client does not work well with protobuf > 3.20.0 and
it should be limited until we solve the problem.
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of an existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in a newsfragment file, named `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [newsfragments](https://github.com/apache/airflow/tree/main/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mikharkiv commented on pull request #25886: Limit Google Protobuf for compatibility with biggtable client
Posted by GitBox <gi...@apache.org>.
mikharkiv commented on PR #25886:
URL: https://github.com/apache/airflow/pull/25886#issuecomment-1246467634
Hello! Thank you for the fix!
As I can see, this affects Google provider too. Can we expect a release for Google provider with this fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25886: Limit Google Protobuf for compatibility with biggtable client
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25886:
URL: https://github.com/apache/airflow/pull/25886#issuecomment-1223255265
Ok. This problem is fixed (wait for PROD image succeeded tests).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mdering commented on pull request #25886: Limit Google Protobuf for compatibility with biggtable client
Posted by "mdering (via GitHub)" <gi...@apache.org>.
mdering commented on PR #25886:
URL: https://github.com/apache/airflow/pull/25886#issuecomment-1424561076
since there isn't much here, i was wondering if this requirement is still necessary or if it could be relaxed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mdering commented on pull request #25886: Limit Google Protobuf for compatibility with biggtable client
Posted by "mdering (via GitHub)" <gi...@apache.org>.
mdering commented on PR #25886:
URL: https://github.com/apache/airflow/pull/25886#issuecomment-1424711300
I'm happy to submit a PR (especially an easy one like this). before I do that, i was wondering if there was any sense of what the issue was that lead to this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #25886: Limit Google Protobuf for compatibility with biggtable client
Posted by GitBox <gi...@apache.org>.
potiuk merged PR #25886:
URL: https://github.com/apache/airflow/pull/25886
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25886: Limit Google Protobuf for compatibility with biggtable client
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #25886:
URL: https://github.com/apache/airflow/pull/25886#issuecomment-1424729082
> I'm happy to submit a PR (especially an easy one like this). before I do that, i was wondering if there was any sense of what the issue was that lead to this.
It did not install back then and broke our tests. The only way to check if it is fixed now is to make a PR and run the tests by doing it. We have 650 dependencies in Airflow. No-one follows every single relase of every one of them - so no-one knows if the problem is fixed.
The only way to see if the problem is fixed is tro try ut.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25886: Limit Google Protobuf for compatibility with biggtable client
Posted by GitBox <gi...@apache.org>.
potiuk commented on PR #25886:
URL: https://github.com/apache/airflow/pull/25886#issuecomment-1246585525
Yes. As usual - regular provider release is coming some time soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25886: Limit Google Protobuf for compatibility with biggtable client
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #25886:
URL: https://github.com/apache/airflow/pull/25886#issuecomment-1424677928
> since there isn't much here, i was wondering if this requirement is still necessary or if it could be relaxed
I think you will never know until you try
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #25886: Limit Google Protobuf for compatibility with biggtable client
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #25886:
URL: https://github.com/apache/airflow/pull/25886#issuecomment-1424678260
PRs are most welcome :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org