You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@carbondata.apache.org by jackylk <gi...@git.apache.org> on 2018/03/12 12:50:55 UTC
[GitHub] carbondata pull request #2053: [CARBONDATA-2247][SDK] Support write Index fi...
GitHub user jackylk opened a pull request:
https://github.com/apache/carbondata/pull/2053
[CARBONDATA-2247][SDK] Support write Index file in CarbonWriter
1. Support write index file in CarbonWriter in SDK
2. Support persist schema in CarbonWriter in SDK
3. Add more testcase in CSVCarbonWriterSuite
- [X] Any interfaces changed?
No
- [X] Any backward compatibility impacted?
No
- [X] Document update required?
No
- [X] Testing done
CSVCarbonWriterSuite
- [X] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
NA
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jackylk/incubator-carbondata writer-support-index
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/carbondata/pull/2053.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2053
----
commit 26b9708af159cdf64aa95c4b97e6315f924782df
Author: Jacky Li <ja...@...>
Date: 2018-03-12T11:38:08Z
support sort_columns
commit 117929cd12acb9b0ad945a6b332b45f1460e206f
Author: Jacky Li <ja...@...>
Date: 2018-03-12T12:34:53Z
support blocksize and add test
----
---
[GitHub] carbondata issue #2053: [CARBONDATA-2247][SDK] Support write Index file in C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2053
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4203/
---
[GitHub] carbondata issue #2053: [CARBONDATA-2247][SDK] Support write Index file in C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2053
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3875/
---
[GitHub] carbondata issue #2053: [CARBONDATA-2247][SDK] Support write Index file in C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2053
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4212/
---
[GitHub] carbondata issue #2053: [CARBONDATA-2247][SDK] Support write Index file in C...
Posted by QiangCai <gi...@git.apache.org>.
Github user QiangCai commented on the issue:
https://github.com/apache/carbondata/pull/2053
LGTM
---
[GitHub] carbondata pull request #2053: [CARBONDATA-2247][SDK] Support write Index fi...
Posted by xuchuanyin <gi...@git.apache.org>.
Github user xuchuanyin commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2053#discussion_r173991546
--- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java ---
@@ -42,6 +45,16 @@
private List<ColumnSchema> otherColumns = new LinkedList<>();
+ private int blockSize;
+
+ public TableSchemaBuilder blockSize(int blockSize) {
+ if (blockSize == 0) {
--- End diff --
Logic and prompt are inconsistent, should be '<='
---
[GitHub] carbondata pull request #2053: [CARBONDATA-2247][SDK] Support write Index fi...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/carbondata/pull/2053
---
[GitHub] carbondata pull request #2053: [CARBONDATA-2247][SDK] Support write Index fi...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on a diff in the pull request:
https://github.com/apache/carbondata/pull/2053#discussion_r174009976
--- Diff: core/src/main/java/org/apache/carbondata/core/metadata/schema/table/TableSchemaBuilder.java ---
@@ -42,6 +45,16 @@
private List<ColumnSchema> otherColumns = new LinkedList<>();
+ private int blockSize;
+
+ public TableSchemaBuilder blockSize(int blockSize) {
+ if (blockSize == 0) {
--- End diff --
ok
---
[GitHub] carbondata issue #2053: [CARBONDATA-2247][SDK] Support write Index file in C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2053
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4262/
---
[GitHub] carbondata issue #2053: [CARBONDATA-2247][SDK] Support write Index file in C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2053
Build Failed with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2958/
---
[GitHub] carbondata issue #2053: [CARBONDATA-2247][SDK] Support write Index file in C...
Posted by jackylk <gi...@git.apache.org>.
Github user jackylk commented on the issue:
https://github.com/apache/carbondata/pull/2053
retest this please
---
[GitHub] carbondata issue #2053: [CARBONDATA-2247][SDK] Support write Index file in C...
Posted by ravipesala <gi...@git.apache.org>.
Github user ravipesala commented on the issue:
https://github.com/apache/carbondata/pull/2053
SDV Build Success , Please check CI http://144.76.159.231:8080/job/ApacheSDVTests/3854/
---
[GitHub] carbondata issue #2053: [CARBONDATA-2247][SDK] Support write Index file in C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2053
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2967/
---
[GitHub] carbondata issue #2053: [CARBONDATA-2247][SDK] Support write Index file in C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2053
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/3018/
---
[GitHub] carbondata issue #2053: [CARBONDATA-2247][SDK] Support write Index file in C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2053
Build Success with Spark 2.1.0, Please check CI http://136.243.101.176:8080/job/ApacheCarbonPRBuilder1/4233/
---
[GitHub] carbondata issue #2053: [CARBONDATA-2247][SDK] Support write Index file in C...
Posted by CarbonDataQA <gi...@git.apache.org>.
Github user CarbonDataQA commented on the issue:
https://github.com/apache/carbondata/pull/2053
Build Success with Spark 2.2.1, Please check CI http://88.99.58.216:8080/job/ApacheCarbonPRBuilder/2989/
---