[GitHub] [superset] kgabryje commented on a change in pull request #18027: fix(generator): more cleanup to plugin framework

[GitBox <gi...@apache.org>]

kgabryje commented on a change in pull request #18027:
URL: https://github.com/apache/superset/pull/18027#discussion_r784952917



##########
File path: superset-frontend/packages/generator-superset/generators/plugin-chart/templates/README.erb
##########
@@ -1,52 +1,40 @@
-## superset-plugin-chart-<%= packageName %>
+# <%= packageName %>
 
-This plugin provides <%= description %> for Superset.
+This is the <%= description %> Superset Chart Plugin.
 
 ### Usage
 
-Configure `key`, which can be any `string`, and register the plugin. This `key` will be used to lookup this chart throughout the app.
+To build the plugin, run the following commands:
 
-```js
-import <%= packageLabel %>ChartPlugin from '@superset-ui/plugin-chart-<%= packageName %>';
+```
+npm i --force

Review comment:
       We can also use `--legacy-peer-deps`, looks a bit less aggressive 😛 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org