You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hbase.apache.org by "Andrew Purtell (JIRA)" <ji...@apache.org> on 2017/08/09 00:35:00 UTC

[jira] [Reopened] (HBASE-18020) Update API Compliance Checker to Incorporate Improvements Done in Hadoop

     [ https://issues.apache.org/jira/browse/HBASE-18020?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Andrew Purtell reopened HBASE-18020:
------------------------------------

Does there need to be a documentation update too. This didn't work for me. On branch-1.4 

./dev-support/checkcompatibility.py --annotation org.apache.hadoop.hbase.classification.InterfaceAudience.Public --annotation org.apache.hadoop.hbase.classification.InterfaceAudience.LimitedPrivate  --include-file "hbase-*" rel/1.3.1 branch-1.4

INFO:root:Source revision: rel/1.3.1
INFO:root:Destination revision: branch-1.4
INFO:root:Applying JAR filename include filter: hbase-*
INFO:root:Filtering classes using 2 annotation(s):
INFO:root:	org.apache.hadoop.hbase.classification.InterfaceAudience.Public
INFO:root:	org.apache.hadoop.hbase.classification.InterfaceAudience.LimitedPrivate
INFO:root:Downloading Java ACC...
INFO:root:Removing scratch dir /data/src/hbase/target/compat-check 
INFO:root:Creating empty scratch dir /data/src/hbase/target/compat-check 
INFO:root:Checking out 1b8ca49af872b63c7b1fbc20a6fdbe71516dd04c in /data/src/hbase/target/compat-check/src
INFO:root:Checking out e9e16b59420c5d9a47b9b014b3bb3cb3421b1de9 in /data/src/hbase/target/compat-check/dst
INFO:root:Building in /data/src/hbase/target/compat-check/src 

...

INFO:root:Will check compatibility between original jars:
	/data/src/hbase/target/compat-check/src/hbase-archetypes/hbase-client-project/target/hbase-client-project-1.3.1.jar

...

and new jars:
	/data/src/hbase/target/compat-check/dst/hbase-archetypes/hbase-shaded-client-project/target/hbase-shaded-client-project-1.4.0-SNAPSHOT.jar

...

Traceback (most recent call last):
  File "./dev-support/checkcompatibility.py", line 514, in <module>
    main()
  File "./dev-support/checkcompatibility.py", line 508, in main
    dst_jars, args.annotations, skip_annotations)
  File "./dev-support/checkcompatibility.py", line 283, in run_java_acc
    "-l", get_repo_name(),
  File "./dev-support/checkcompatibility.py", line 126, in get_repo_name
    cwd=get_repo_dir()).strip()
  File "./dev-support/checkcompatibility.py", line 71, in check_output
    raise error
subprocess.CalledProcessError: Command '['git', 'config', '--get', 'remote.origin.url']' returned non-zero exit status 1

[apurtell@ip-172-31-47-35 hbase]$ git --version
git version 1.7.1


> Update API Compliance Checker to Incorporate Improvements Done in Hadoop
> ------------------------------------------------------------------------
>
>                 Key: HBASE-18020
>                 URL: https://issues.apache.org/jira/browse/HBASE-18020
>             Project: HBase
>          Issue Type: Improvement
>          Components: API, community
>            Reporter: Alex Leblang
>            Assignee: Alex Leblang
>             Fix For: 2.0.0, 3.0.0, 1.4.0, 1.3.2, 1.5.0, 1.2.7, 1.1.12
>
>         Attachments: HBASE-18020.0.patch, HBASE-18020.branch-1.2.001.patch, HBASE-18020.branch-1.2.002.patch, HBASE-18020.branch-1.2.003.patch, HBASE-18020.branch-1.2.004.patch
>
>
> Recently the Hadoop community has made a number of improvements in their api compliance checker based on feedback from the hbase and kudu community. We should adopt these changes ourselves.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)