You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/08/23 20:58:15 UTC
[GitHub] [arrow-nanoarrow] lidavidm opened a new issue, #33: Ensure headers are in a subdirectory?
lidavidm opened a new issue, #33:
URL: https://github.com/apache/arrow-nanoarrow/issues/33
Right now, the assumption appears to be we `#include <nanoarrow.h>` as it in turn `#include <typedefs_inline.h>`. It might be better to assume headers are in a subdirectory, like `#include <nanoarrow/nanoarrow.h>` and `#include <nanoarrow/typedefs_inline.h>`, to risk the chance of clashes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] lidavidm closed issue #33: Ensure headers are in a subdirectory?
Posted by GitBox <gi...@apache.org>.
lidavidm closed issue #33: Ensure headers are in a subdirectory?
URL: https://github.com/apache/arrow-nanoarrow/issues/33
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot commented on issue #33: Ensure headers are in a subdirectory?
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #33:
URL: https://github.com/apache/arrow-nanoarrow/issues/33#issuecomment-1225679076
I'm not convinced that I did the right thing here! I'm not a good candidate to know what the best practice is for any kind of distribution of compiled code (mostly my experience is with questionable techniques for vendoring libraries since I've done most of them...). Let's revisit after I start writing up a tutorial on how to vendor/use the C library.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] lidavidm commented on issue #33: Ensure headers are in a subdirectory?
Posted by GitBox <gi...@apache.org>.
lidavidm commented on issue #33:
URL: https://github.com/apache/arrow-nanoarrow/issues/33#issuecomment-1225080469
Hmm, I hadn't realized quotes also (typically, but not guaranteed) searches the current directory first. That probably works well enough then.
SQLite etc. do pre-generate a single header file (and check it in?), which would also work. (Not sure how you can make CMake do this, though.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] lidavidm commented on issue #33: Ensure headers are in a subdirectory?
Posted by GitBox <gi...@apache.org>.
lidavidm commented on issue #33:
URL: https://github.com/apache/arrow-nanoarrow/issues/33#issuecomment-1225086510
Ah ok, clearly I wasn't paying attention - I'll give that a try then. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot commented on issue #33: Ensure headers are in a subdirectory?
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #33:
URL: https://github.com/apache/arrow-nanoarrow/issues/33#issuecomment-1225072272
I'm very new to all of this and I'm happy to defer to best practice! I thought that I had used quote-includes rather than bracket includes (i.e., `#include "typedefs_inline.h"`) because I thought that searched the local directory first rather than the `-I` compiler flag directories first, and I'd kind of assumed that any vendoring method would just copy the files together. (Again, very new to this and happy to do whatever!).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-nanoarrow] paleolimbot commented on issue #33: Ensure headers are in a subdirectory?
Posted by GitBox <gi...@apache.org>.
paleolimbot commented on issue #33:
URL: https://github.com/apache/arrow-nanoarrow/issues/33#issuecomment-1225084495
I think I did that (at least added the option to generate a single header and single source file) in #31! https://github.com/apache/arrow-nanoarrow/pull/31/files#diff-1e7de1ae2d059d21e1dd75d5812d5a34b0222cef273b7c3a2af62eb747f9d20aR29-R65
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org